- This topic has 121 replies, 22 voices, and was last updated 6 years, 5 months ago by Tom.
-
AuthorPosts
-
October 25, 2017 at 7:22 pm #410382TomLead DeveloperLead Developer
Thank you! Patched π
October 25, 2017 at 8:59 pm #410410SamuelI’m using the current beta to convert a new site over to GP. One of the things I need to do is insert new content right after the header and the generate_after_header hook seems to have a bug in it. that hook runs right after the menu/logo area, it does not run after the entire page header. I’ve looked and looked for another hook but it doesn’t seem there is one so I’m guessing this is a bug (or another hook is needed) since there’s no way to insert content after the entire header if you’re using the page headers functionality.
October 25, 2017 at 9:52 pm #410432TomLead DeveloperLead DeveloperYou’d need to write a function to hook into that hook with a greater priority than the page header.
For example:
add_action( 'generate_after_header', 'tu_after_page_header', 50 ); function tu_after_page_header() { ?> Your content in here <?php }
Adding PHP: https://docs.generatepress.com/article/adding-php/
October 26, 2017 at 3:11 am #410519DuncanHey Tom,
Lovely update, really enjoying using this.
Couple of requests/suggestions:
- Would it be possible to add a ‘Display Comments’ checkbox to the Blog > Content > Single panel? Seems like a sensible place to allow us a nice, easy way to toggle this.
- It would also be nice to have some options on the ‘Post Navigation’ – I know this can be achieved with css, but the option to display next/previous post links inline, display as buttons and even reverse the order (so that the previous posts link is on the right and later posts on the left).
Thanks
Duncan
October 26, 2017 at 6:07 am #410573SamuelTom,
Thank you. That worked perfectly.
Samuel
October 26, 2017 at 10:08 am #410783TomLead DeveloperLead DeveloperHi Duncan,
1. Displaying the actual comments should be handled by WordPress itself. They have on-page options, as well as a global option in “Settings > Discussion”.
2. I agree – I could see those becoming options soon.
Thank you!
Samuel – glad I could help! π
November 3, 2017 at 1:21 pm #415806TomLead DeveloperLead DeveloperJust released GPP 1.5-rc.3 with the following changes:
– Blog: Add featured image options specific to pages
– Page Header: Fix custom images not displaying
– Page Header: Fix image link option not working
– German translations updated (thanks, Daniel!)November 3, 2017 at 1:23 pm #415807AntarGreat stuff, Tom.
Thank you for keeping it coming! π
November 6, 2017 at 9:33 am #417250RustI didnt download 1.5 but i have 1.4.
Tom, please fix that:
in 1.4 version, When I’m on the main page, the logo link is active and leads to itself. The same applies to all sections of the menu. If the menu consists of a category, when I’m on some category, then its name continues to remain clickable. this is not very good from the point of view of SEO.sorry for my bad english, i dont speak english.
November 6, 2017 at 9:47 am #417262TomLead DeveloperLead DeveloperHi there,
Any chance you can open a new topic?
Thanks!
November 7, 2017 at 5:56 am #417729EnricoHi Tom,
for your information after I installed WordPress 4.9-RC2-42125 the functionality “page header location” is not working anymore.It was set to “Inside content area” but now it behave like if it is set to: “Above content area”
This is not limited to one site, but I see this problem on each site upgraded to 4.9-RC2-42125 with GP 1.5 RC3
November 7, 2017 at 8:40 am #417876ToddI am unable to force the plugins to indicate that the GP Premium 1.5 plugin is available. I added Code Snippets, and supplied it the following code:
add_action( 'after_setup_theme','tu_beta_tester' ); function tu_beta_tester() { add_filter( 'generate_premium_beta_tester','__return_true' ); }
I also tried adding this PHP to the functions.php of my child theme, but no dice.
Unfortunately, my site is behind a firewall.
Would the header of my child theme have any bearing on why I can’t force the plugin to recognize that the beta is available for download?
/* Theme Name: GeneratePress Child Theme URI: https://generatepress.com/generatepress-child/ Author: Todd Wheeler Author URI: http://172.20.3.101 Template: generatepress Description: GeneratePress Child Theme Version: 1.3.44 License: GNU General Public License v2 or later License URI: http://www.gnu.org/licenses/gpl-2.0.html Text Domain: generatepress-child Tags: two-columns, three-columns, one-column, right-sidebar, left-sidebar, footer-widgets, blog, e-commerce, flexible-header, full-width-template, buddypress, custom-header, custom-background, custom-menu, custom-colors, sticky-post, threaded-comments, translation-ready, rtl-language-support, featured-images, theme-options GeneratePress, Copyright 2017 Tom Usborne GeneratePress is distributed under the terms of the GNU GPL GeneratePress is based on Underscores http://underscores.me/, (C) 2012-2017 Automattic, Inc. */
I’ve cleared the cache, restarted the webserver, used both Safari and Chrome on the Mac. My license appears to be active.
November 7, 2017 at 8:50 am #417896TomLead DeveloperLead DeveloperEnrico – featured images are handled in Customize > Layout > Blog now.
Todd – sometimes it takes a little bit to check for the update, can you let me know if it still hasn’t shown up in an hour or so?
Thanks!
November 7, 2017 at 9:52 am #417949ToddHi Tom,
Thanks for the response!I’ve actually been trying to enable this for a week.
Does this screenshot help?
November 7, 2017 at 11:03 am #417987EnricoThanks a lot Tom,
Unfortunately the problem is not changed.
I didn’t change it since a long time so I didn’t notice the new place to set it. When I upgraded gp from 1.4 to 1.5 it kept my old setting.Now, after I upgraded to wp 4.9 rc2 “below content” don’t work in pages, not even if I set it correctly as you told me to do.
-
AuthorPosts
- The topic ‘GP Premium 1.5’ is closed to new replies.