[Resolved] Comments title not translated

Home Forums Support [Resolved] Comments title not translated

Home Forums Support Comments title not translated

Viewing 14 posts - 16 through 29 (of 29 total)
  • Author
    Posts
  • #294120
    Tom
    Lead Developer
    Lead Developer

    No problem, thanks for pointing out the issue 🙂

    #327068
    ocan

    Hi there

    I have the same problem but with the french translation.

    In the comments section everything is translated but the title wich is

    2 thoughts on “Accueil”

    All other fields are ok and translated (modify, respond, Leave a comment, publish comment)

    Beside that I would like the title to be “comments” or the french translation “Commentaires” and not having the name of the page on it like “thoughts on Homepage_Title”

    Of course I could go .comments-title display none but I want A generic title for the readers like “Comments” or the french translation of it (Commentaires)

    How can I do that?

    The update section states :
    Thèmes
    Vos thèmes sont tous à jour. (theme up to date)

    Traductions
    Vos traductions sont toutes à jour. (translations up to date)

    I have another issue still with comments but I will open another thread about it

    Thanks for your help Tom

    #327450
    Tom
    Lead Developer
    Lead Developer

    Hi there,

    You should be able to change this in the generatepress.po file in wp-content/languages/themes.

    You could also use a plugin like this: https://en-ca.wordpress.org/plugins/say-what/

    The string would be: One thought on “%s”

    The text domain is: generatepress

    #327583
    ocan

    Hi Tom

    Thank you for your help and for letting me know about this handy plugin!

    Unfortunatly, I tried something on my side while waiting for your response :

    – Created a child theme
    – Copy pasted the comment php file in the child folder

    Modified the following :
    Original :
    esc_html_x( 'One thought on “%s”', 'comments title', 'generatepress' ),
    Modified:
    esc_html_x( 'Un commentaire', 'comments title', 'generatepress' ),

    and in the Else part
    Original

    '%1$s thought on “%2$s”',
    '%1$s thoughts on “%2$s”',

    Modified

    '%1$s Commentaire',
    '%1$s Commentaires',

    I wasnt sure about this because it seems that the before else part is related to one comment only, but the else seems to overrule (If I have a single comment, I have ‘1 comment’ displayed and not ‘ONE comment’

    Well anyway that fixed my problem but I wanted to know if it might be messy when a future update kicks in?

    I dont know anything about code beside what I learned myself and I hope I didnt messed up

    Thank you Tom

    #327716
    Tom
    Lead Developer
    Lead Developer

    That’s definitely an option. The only issue there is you won’t receive any updates to that file if I make changes in future versions.

    #355891
    Marcel

    Hi there!
    Excuse me, but I’m al little confused with the german and the french solution.
    It seems as though I have the same problem with my page:
    http://www.elvispapa.de/2017/07/22/erster-tag/

    Where it says
    ‘1 thought on “<post-title>”‘ it should say
    ‘1 Kommentar zu “<post-title>”‘.

    I updated my WordPress half an hour ago.
    Dashboard/Updates/Translations says ‘translations are up-to-date’.

    #356072
    Marcel

    I’ve tried the say-what-plugin using the strings provided in (the fuzzy) ‘Translation of GeneratePress’ @ https://translate.wordpress.org/projects/wp-themes/generatepress/de/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=354251&filters%5Btranslation_id%5D=45178821.

    Don’t see any difference on the webpage, though.
    Any chance on helping me out on this one?
    That’d be great!

    #356127
    Tom
    Lead Developer
    Lead Developer

    What did you add as the text domain in Say What?

    #356145
    Marcel

    I added “generatepress” as the ‘text domain’ (as you suggested in one of the earlier posts of this thread).
    I left ‘text context’ blank.

    #356553
    Tom
    Lead Developer
    Lead Developer

    I just ran a test and didn’t notice any issues: https://www.screencast.com/t/lKwySYvLbFZY

    I went into “Settings > General” and set my Site Language as: Deutsch

    Then I went into “Dashboard > Updates” and updated my translations.

    If you’ve done the above, do you have any custom functions or files in your child theme?

    #356632
    Marcel

    Thanks, Tom.
    That did the trick – at least for Site Language “Deutsch”.

    My “Settings > General > Site Language” were set to “Deutsch (Sie)” which means German, using the formal form of ‘you’.

    Personally I prefer the informal you. But most of my fellow Germans prefer the formal you – especially when it’s about integrity (e.g. of a web-page).

    If I could choose I’d rather use the formal form of German (“Deutsch (Sie)”) and alter the comments-title to ‘1 Kommentar zu “<post-title>”’.

    Can I achieve that by using the Say-What-Plugin?
    It didn’t really work out in my first try.

    Thanks so far.
    Marcel

    #356937
    Tom
    Lead Developer
    Lead Developer

    Say What should be able to handle it.

    If not, we just need to get this translations to 96% accepted (at least) so the new translations ship: https://translate.wordpress.org/locale/de/formal/wp-themes/generatepress

    #356955
    Marcel

    Thanks a lot, Tom.
    I’ll have a go at it later on.

    For now I have tried to fill up the gaps in the Translation of GeneratePress: German (Formal).
    Not sure if or how I am entitled to approve other people’s suggestions to switch them from ‘Waiting’ to ‘Current’, to push the 91% up to >96%.

    #357170
    Tom
    Lead Developer
    Lead Developer

    I’ve notified one of the editors that should be able to approve them.

    Thank you! 🙂

Viewing 14 posts - 16 through 29 (of 29 total)
  • You must be logged in to reply to this topic.