- This topic has 14 replies, 3 voices, and was last updated 5 years, 10 months ago by Tom.
-
AuthorPosts
-
June 11, 2018 at 4:39 pm #597741arthur
Hi it looks like someone switched to the flex box models for product images in woocommerce. Personally I hate that model, because it is very confusing, but I digress. That is not the point of this π
I want to create spacing between the main image and the thumbs. I want to create spacing between the thumbnails. And I would most prefer to introduce a border, but I can live without it.
I have GP premium and thought it would be part of the ‘spacing’ plugin, but no such luck….
I’m happy to load in CSS to accomplish this – but I have no idea what to write. I tried a few things, but again, that flex-box model……
Thanks!
June 11, 2018 at 4:55 pm #597752LeoStaffCustomer SupportHi there,
Any chance you can link me to the site in question?
You can edit the original topic and use the private URL field.
Let me know π
June 11, 2018 at 5:36 pm #597766arthurI need to also give you the login url and a username and password so you can see the issue….how do I send a private note or private reply?
June 11, 2018 at 6:48 pm #597802LeoStaffCustomer SupportYou can use Account Issue here: https://generatepress.com/contact/
Make sure to reference topic URL.
Thanks!
June 11, 2018 at 7:06 pm #597808arthurdone thanks
June 11, 2018 at 8:09 pm #597830TomLead DeveloperLead DeveloperHi there,
Try this:
.woocommerce div.product div.images .flex-control-thumbs { margin-top: 10px; } .woocommerce div.product div.images .flex-control-thumbs li { border: 10px solid #fff; box-sizing: border-box; }
Let me know if this helps or not π
June 11, 2018 at 8:18 pm #597838arthurLooks really good!!
I didn’t like that the thumbs then did not extend to the same side-to-side edge as the main photo.
So I tweaked the code and added negative margins to the container.
QUESTION: I don’t understand the flex-box model enough to understand if this will have further repercussions. Do you think this is a good solution or is there a better, less dangerous one?
Updated code is here:
.woocommerce div.product div.images .flex-control-thumbs { margin-top: 10px; margin-left: -10px; margin-right: -10px; } .woocommerce div.product div.images .flex-control-thumbs li { border: 10px solid #fff; box-sizing: border-box; }
June 11, 2018 at 8:20 pm #597841TomLead DeveloperLead DeveloperThat looks good to me – you shouldn’t have any issues π
June 11, 2018 at 8:21 pm #597842arthurThanks!
June 11, 2018 at 8:21 pm #597843arthurPS do you now use the flex-box model for all of generate press? Did you add that in or did WooCommerce start adding that in?
June 11, 2018 at 8:26 pm #597844TomLead DeveloperLead DeveloperHaha, whoops – yes, I meant shouldn’t.
We added flexbox for our mobile header, but that’s it.
We’ll likely move to a CSS Grid solution for WooCommerce soon.
June 11, 2018 at 8:28 pm #597845arthurWeβll likely move to a CSS Grid solution for WooCommerce soon.
Does that mean that you’ll move the flex-box woocommerce code out of flex-box and into a normal CSS Grid?
June 12, 2018 at 8:40 am #598352TomLead DeveloperLead DeveloperIf necessary. If the way they have it now works with the way we approach things, we’ll likely leave it.
June 12, 2018 at 1:00 pm #598529arthurokay cool thx!
June 12, 2018 at 3:27 pm #598616TomLead DeveloperLead DeveloperYou’re welcome π
-
AuthorPosts
- You must be logged in to reply to this topic.