- This topic has 20 replies, 4 voices, and was last updated 1 year, 1 month ago by David.
July 2, 2022 at 7:20 am #2271108GenStone88
As requested by David, I’m opening a new topic to pinpoint the issue described here:
I have now created a test environment that you can access, and I have confirmed that the issue occurs in this environment. See private information submitted with this topic for details on where to access this environment.
It’s basically an almost empty WordPress environment:
1. All plugins are disabled.
2. GP theme installed.
3. Back to Top button enabled.
4. Only a homepage with some content, containing some links to test the issue.
Steps to reproduce the issue:
1. Open the homepage in Chrome on an IOS device. (I tested with an iPad Mini and an iPhone 13 Pro, running the latest version of IOS)
2. Scroll down so that the Back to Top button appears, and then scroll down a bit further.
3. Here you find links back to the homepage as well as external links.
4. The issue occurs frequently, both on the internal and the external links. It won’t occur every time you attempt but in my case I’d say about 50%-75% roughly, so it’s very easy to reproduce.
1. The issue also occurs for the Back to Top button itself, it often requires 2 taps before scrolling up when following the steps above and then tapping the Back to Top button instead of a link.
2. It seems that the issue occurs only once for each page load. If you have encountered the issue using the Back to Top button or an external link (opening in a new tab), so that you stay on the same page, then the issue won’t occur again until you refresh the page.
Hopefully you can now also produce the issue and say something about what we can do about it?July 2, 2022 at 7:57 am #2271256DavidStaffCustomer Support
thanks for setting this up.
On refresh sometimes the back to top requires a double tap probably 7 out of 10 times. Hmmm.
But the links in the content, internal or external, they work everytime for me on my iPhone.
Chrome on iOS is a pain in the *** to debug as its a webViews app.
I am going to ask Tom to take a look too, so we can knock our heads together and see what we can come up with.
Are you ok leaving that staging site up for a while ?July 2, 2022 at 8:24 am #2271278GenStone88
Thanks for checking!
Yes absolutely, I’ll leave it up as it currently is. Just let me know if we need to change/test something.
Just tested again myself, and I continue to have the issue also for the links, so in my case it’s definitely not just the back to top button itself that needs a double tap.July 2, 2022 at 8:29 am #2271284DavidStaffCustomer Support
I opened an issue here so we can track it as a potential bug:
We’ll keep you posted.August 2, 2022 at 4:36 am #2300606GenStone88
Just want to check if you still need the staging site to debug this issue further or did you have a chance to take the info you need from the staging site now?
Asking as I need to replace it in the near future, and at that point it would also be good if you can remove the reference to the staging site url/details from this support ticket (even if it’s not resolved yet at that point).
For now, I’ll leave the staging site as it is but thought I’d give you a heads-up instead of just replacing it at some point.August 17, 2022 at 9:59 am #2315794TomLead DeveloperLead Developer
Thanks for keeping the staging site up – still trying to debug this!
Is there any chance you can share login details for it so I can turn on/off the back to top button?August 17, 2022 at 2:22 pm #2315980TomLead DeveloperLead Developer
Ah, scratch that! Was able to replicate with the content from your staging site.
I believe I have the fixes ready to go here: https://github.com/tomusborne/generatepress/pull/421
Let me know if you’re able to test those changes and if they work or not.
Thanks!August 18, 2022 at 4:38 am #2316415GenStone88
Hi Tom, thanks for the update!
I tested the fix on the staging site and it does indeed remove the need to double tap:) However, it does introduce a new issue it seems, as now the back to top button is always visible immediately on page load. It doesn’t just pop up after scrolling down, it’s simply always visible.
Might that be an issue related to the fix or did I do something wrong?
To test I first only uploaded the changes (from the 4 files) related to the relevant commit.
After noticing the issue mentioned above I also tried uploading all the files from the “improve-back-to-top” branche but the result is the same.August 18, 2022 at 6:04 am #2316486DavidStaffCustomer Support
Do you have any server caches on the site, if so try clearing those to see if it clears the ‘new’ issueAugust 18, 2022 at 6:24 am #2316511GenStone88
I did consider that and pressed cache clear several times before posting my results, however, I understand your concern with cache. Just to be sure I just double checked but server cache is actually disabled in the staging environment. Nevertheless, I again cleared the cache just now in WordPress as well as on the server level (even though it’s disabled anyway) but the issue remains also after that.
So something else must be causing it?August 18, 2022 at 7:04 am #2316564DavidStaffCustomer Support
Try deactivating the Back to Top in the Customizer, publish the changes and then re-activate it.August 18, 2022 at 8:35 am #2316776GenStone88
Brilliant! That fixed it!
So indeed that wasn’t an issue in the code update:)
I noticed now that the customizer option “Cache dynamic CSS” is enabled in this environment so perhaps that cached CSS needed refreshing, or something else was refreshed by disabling and then once again enabling the Back to Top button.
Anyway, it seems all good now in the staging environment. No more double tap issues, and the Back to Top button only appears after scrolling down a bit.
Any idea on when this awesome fix might make its way into an official release?August 19, 2022 at 2:10 am #2317290DavidStaffCustomer Support
Great to hear thats working. Its tagged for GP 3.2 release, which i would expect to see an alpha for in the next few weeks.August 19, 2022 at 2:14 am #2317297GenStone88
Awesome! I’ll now mark this issue as resolved as the fix is coming in the release.
Thanks for the great support and fix!August 19, 2022 at 2:50 am #2317325DavidStaffCustomer Support
Thank you for your patience and testing – and especially keeping the staging site open !!
- You must be logged in to reply to this topic.