Site logo

[Resolved] AMP Validation Error Index in GeneratePress Theme

Home Forums Support [Resolved] AMP Validation Error Index in GeneratePress Theme

Home Forums Support AMP Validation Error Index in GeneratePress Theme

Viewing 15 posts - 31 through 45 (of 45 total)
  • Author
    Posts
  • #1363553
    infocus

    1 – Disable Official AMP + AMP for GP ( why you need Two Plugin for One function ? )

    I don’t need two plugins to enable AMP in GP, is GP that need two Plugins. This is what Tom say.

    GP is light, i know, but i am not Google, Google want AMP, then i will give to Google AMP.

    #1363625
    Tom
    Lead Developer
    Lead Developer

    Is there any chance you can re-take those screenshots in English so I know exactly what your setup is?

    Let me know 🙂

    #1363647
    infocus

    Hello Tom,
    goor to see you again.
    I record a Video, is more easy to see.

    http://somup.com/cYi2rdQ9nj

    #1364571
    Tom
    Lead Developer
    Lead Developer

    The click dropdown options require javascript, so they won’t work when AMP is enabled. It will automatically set things to “hover” if AMP is activated, as hover is CSS-only.

    #1364613
    infocus

    Apparently it can be build with CSS only: https://www.briankephart.com/dropdowns-without-javascript

    About AMP in Generatepress, when you think that AMP is here for stay?

    #1364911
    Tom
    Lead Developer
    Lead Developer

    In this case, it’s not possible to use CSS-only. That example if using a single checkbox, which won’t work with individual menu items.

    We’ll definitely be keeping AMP support separate in an effort to keep the theme as light as possible.

    #1365573
    infocus

    Good thank you Tom.

    About AMP in WordPress, i did yesterday an article of How to Activate AMP for GeneratePress, this an article in spanish and i want to share with all you, mainly spanish readers:
    AMP para GeneratePress.

    #1365885
    Tom
    Lead Developer
    Lead Developer

    Awesome, thanks for sharing! 🙂

    #1378668
    Edwin

    Hello, I dared to put AMP on my site and followed the advice of the article that Marcelo wrote, but for some reason my navigation bar got messy, even the search icon disappears, I have premium gp, and betas activated maybe I have something wrong Could you support me? I leave the site, by the way I also have a WordPress multisite.

    http://www.egatimes.com

    by the way, the problem is only for the version of mobile devices

    Regards

    #1378989
    David
    Staff
    Customer Support

    Hi there,

    did you install the AMP for GeneratePress plugin?

    https://github.com/tomusborne/amp-for-generatepress

    Note: Elements that require JS do not work in AMP.

    #1379005
    Edwin

    yes 2, install the official plugin and the amp to generatepress and everything worked correctly but on mobile devices the order moves and the search icon is hidden.
    I didn’t know there were js elements to be disabled, in fact my problem is short, because I had the logo and the menu on the same line of the navigation bar, and I can’t make them stay like this, the menu always comes down I think that I will have to play with all the settings to get it ready, by the way, that does not work js makes the menu no longer go from one side to another? because now it just pops up from top to bottom, and when it’s visible it pushes the whole page down and comes back when I close the menu.

    #1379456
    Tom
    Lead Developer
    Lead Developer

    Hi there,

    You may be able to add this:

    .mobile-header-navigation .site-logo.mobile-header-logo amp-img {
        max-width: 100px;
    }
    #1379979
    Edwin

    Hi good day.
    I was doing tests and I see that when I activate the official AMP plugin is when it happens that my fixed navigation moves, I tried everything with premium gp and amp for generatepress activated, I tried one by one deactivating other plugins and only the official amp gives me the problem .I added the code that you put me but still it is as if it did not work.
    Right now I am doing more tests and it scares me because I do not have much css knowledge but I am brave haha.

    regards!

    #1380024
    Edwin

    Great!
    I decided to remove the amp for generatepress plugin and just put the code you suggested, and after a thousand tries it finally worked! Thanks Tom and David, by the way I love generatepress!
    Greetings from Puerto Vallarta, Mexico !.
    I had written in Spanish haha

    #1380782
    Tom
    Lead Developer
    Lead Developer

    Glad you got it working 🙂

Viewing 15 posts - 31 through 45 (of 45 total)
  • You must be logged in to reply to this topic.