- This topic has 44 replies, 5 voices, and was last updated 5 years, 8 months ago by
Tom.
-
AuthorPosts
-
July 14, 2020 at 1:04 pm #1363553
infocus
1 – Disable Official AMP + AMP for GP ( why you need Two Plugin for One function ? )
I don’t need two plugins to enable AMP in GP, is GP that need two Plugins. This is what Tom say.
GP is light, i know, but i am not Google, Google want AMP, then i will give to Google AMP.
July 14, 2020 at 2:39 pm #1363625Tom
Lead DeveloperLead DeveloperIs there any chance you can re-take those screenshots in English so I know exactly what your setup is?
Let me know 🙂
July 14, 2020 at 2:51 pm #1363647infocus
Hello Tom,
goor to see you again.
I record a Video, is more easy to see.July 15, 2020 at 8:56 am #1364571Tom
Lead DeveloperLead DeveloperThe click dropdown options require javascript, so they won’t work when AMP is enabled. It will automatically set things to “hover” if AMP is activated, as hover is CSS-only.
July 15, 2020 at 9:27 am #1364613infocus
Apparently it can be build with CSS only: https://www.briankephart.com/dropdowns-without-javascript
About AMP in Generatepress, when you think that AMP is here for stay?
July 15, 2020 at 2:24 pm #1364911Tom
Lead DeveloperLead DeveloperIn this case, it’s not possible to use CSS-only. That example if using a single checkbox, which won’t work with individual menu items.
We’ll definitely be keeping AMP support separate in an effort to keep the theme as light as possible.
July 16, 2020 at 7:18 am #1365573infocus
Good thank you Tom.
About AMP in WordPress, i did yesterday an article of How to Activate AMP for GeneratePress, this an article in spanish and i want to share with all you, mainly spanish readers:
AMP para GeneratePress.July 16, 2020 at 9:26 am #1365885Tom
Lead DeveloperLead DeveloperAwesome, thanks for sharing! 🙂
July 27, 2020 at 7:03 pm #1378668Edwin
Hello, I dared to put AMP on my site and followed the advice of the article that Marcelo wrote, but for some reason my navigation bar got messy, even the search icon disappears, I have premium gp, and betas activated maybe I have something wrong Could you support me? I leave the site, by the way I also have a WordPress multisite.
by the way, the problem is only for the version of mobile devices
Regards
July 28, 2020 at 3:25 am #1378989David
StaffCustomer SupportHi there,
did you install the AMP for GeneratePress plugin?
https://github.com/tomusborne/amp-for-generatepress
Note: Elements that require JS do not work in AMP.
July 28, 2020 at 3:40 am #1379005Edwin
yes 2, install the official plugin and the amp to generatepress and everything worked correctly but on mobile devices the order moves and the search icon is hidden.
I didn’t know there were js elements to be disabled, in fact my problem is short, because I had the logo and the menu on the same line of the navigation bar, and I can’t make them stay like this, the menu always comes down I think that I will have to play with all the settings to get it ready, by the way, that does not work js makes the menu no longer go from one side to another? because now it just pops up from top to bottom, and when it’s visible it pushes the whole page down and comes back when I close the menu.July 28, 2020 at 8:57 am #1379456Tom
Lead DeveloperLead DeveloperHi there,
You may be able to add this:
.mobile-header-navigation .site-logo.mobile-header-logo amp-img { max-width: 100px; }July 28, 2020 at 9:57 pm #1379979Edwin
Hi good day.
I was doing tests and I see that when I activate the official AMP plugin is when it happens that my fixed navigation moves, I tried everything with premium gp and amp for generatepress activated, I tried one by one deactivating other plugins and only the official amp gives me the problem .I added the code that you put me but still it is as if it did not work.
Right now I am doing more tests and it scares me because I do not have much css knowledge but I am brave haha.regards!
July 28, 2020 at 11:42 pm #1380024Edwin
Great!
I decided to remove the amp for generatepress plugin and just put the code you suggested, and after a thousand tries it finally worked! Thanks Tom and David, by the way I love generatepress!
Greetings from Puerto Vallarta, Mexico !.
I had written in Spanish hahaJuly 29, 2020 at 9:02 am #1380782Tom
Lead DeveloperLead DeveloperGlad you got it working 🙂
-
AuthorPosts
- You must be logged in to reply to this topic.