- This topic has 11 replies, 2 voices, and was last updated 3 years, 5 months ago by Tom.
-
AuthorPosts
-
October 9, 2020 at 5:46 pm #1481291forgemedia
Hey guys!
Awesome job on the updates to GP 3.0. I’ve found a few things since moving all my sites across and thought I would round them all up into one forum post. Note: I’m using Flexbox.Widget text size
On all the sites I updated, the size of the text in a footer widget was always overridden by the size of the font for the body. The font size for a widget actually doesn’t seem to work at all.Typography > Widgets > Content Font Size
I have it set to 17px in the Customizer, but it’s getting override with 19px from main body content size.
I had to add this code to all my sites, which shouldn’t be needed.
.sidebar .widget, .footer-widgets .widget {font-size:17px;}
EDD page
On the EDD purchase confirmation page (“View details and download”) the main content div seems to be stopping short and the content (billed to address and sold by address) is overlapping it. See image here: https://imgur.com/a/Y0Z30okHope this helps!
BrianOctober 10, 2020 at 9:47 am #1482281TomLead DeveloperLead DeveloperHere I was thinking it only took one patch to make things stable. Thanks Brian! π
Indeed bugs – will get these fixed in 3.0.2. Appreciate you pointing them out – thank you!
October 11, 2020 at 12:25 pm #1483741forgemediaHaha, ya looks like you’ve been busy. π
Keep up the great work.
October 11, 2020 at 8:58 pm #1484093TomLead DeveloperLead DeveloperHow can I replicate the EDD thing? Can you share your content with shortcodes on that page maybe?
Thanks!
October 11, 2020 at 9:14 pm #1484095forgemediaI’m using the default EDD purchase confirmation page (view details and downloads).
This is the entire code/content on the page:
Thank you for your purchase! [[edd_receipt]]
You need to actually have a purchase in there to test it though, because the
[[edd_receipt]]
shortcode generates all that content which then overlaps the page div. It’s also easier to see if you have a different background color from your main content set on the page.FYI, I temporarily fixed it by adding this to my sites.
#post-2280 .inside-article {overflow:auto;}
The post ID is obviously unique to each EDD page. So I added the above across my three EDD sites, with their own unique post ID.Let me know if you need more information.
Thanks
October 11, 2020 at 11:47 pm #1484200TomLead DeveloperLead DeveloperStrange – not able to reproduce on my end of things. It also looks like floats aren’t being cleared, but GP itself isn’t using any floats like this.
Is this something you’re able to reproduce on a default install?
October 12, 2020 at 5:04 pm #1485765forgemediaHey Tom,
After some more testing, I discovered it was coming from Easy Digital Downloads EU VAT extension.
They are basically just floating left the two info boxes below all the default EDD stuff.I’m going to ping the team over at barn2.co.uk. As this is actually coming from their CSS (stylesheet). So I don’t think it’s something you need to worry about. They probably just need to account for sites now that might be using Flexbox with GeneratePress.
October 12, 2020 at 7:35 pm #1485873TomLead DeveloperLead DeveloperCool – thanks for taking the time to test it!
Widget content font size bug is fixed in 3.0.2 which will be released this week π
October 12, 2020 at 7:37 pm #1485877forgemediaAwesome thanks! Keep up the great work.
October 12, 2020 at 7:38 pm #1485880TomLead DeveloperLead DeveloperYou too! Mentioned permatters in our speed article re-write: https://generatepress.com/fastest-wordpress-theme/
October 12, 2020 at 7:43 pm #1485881forgemediaWow, thanks. I’ll help share the post around and will drop it in my next newsletter.
October 12, 2020 at 7:48 pm #1485884TomLead DeveloperLead DeveloperIt’s no Brian Jackson article, but I tried! π
Thanks!
-
AuthorPosts
- You must be logged in to reply to this topic.