- This topic has 66 replies, 5 voices, and was last updated 3 years, 6 months ago by
Karen.
-
AuthorPosts
-
October 24, 2022 at 3:09 pm #2384680
Karen
Thanks David! This looks better. It’s still getting the below error but I think ED said I could ignore it. I’m going to see if it’s a legit okay or not.
<span class=”gp-icon icon-search”><svg viewbox=”0 0 512 512″ aria-hidden=”true” xmlns=”http://www.w3.org/2000/svg” width=”1em” height=”1em”><path fill-rule=”evenodd” clip-rule=”evenodd” d=”M208 48c-88.366 0-160 71.634-160 160s71.634 160 160 160 160-71.634 160-160S296.366 48 208 48zM0 208C0 93.125 93.125 0 208 0s208 93.125 208 208c0 48.741-16.765 93.566-44.843 129.024l133.826 134.018c9.366 9.379 9.355 24.575-.025 33.941-9.379 9.366-24.575 9.355-33.941-.025L337.238 370.987C301.747 399.167 256.839 416 208 416 93.125 416 0 322.875 0 208z” /></svg><svg viewbox=”0 0 512 512″ aria-hidden=”true” xmlns=”http://www.w3.org/2000/svg” width=”1em” height=”1em”><path d=”M71.029 71.029c9.373-9.372 24.569-9.372 33.942 0L256 222.059l151.029-151.03c9.373-9.372 24.569-9.372 33.942 0 9.372 9.373 9.372 24.569 0 33.942L289.941 256l151.03 151.029c9.372 9.373 9.372 24.569 0 33.942-9.373 9.372-24.569 9.372-33.942 0L256 289.941l-151.029 151.03c-9.373 9.372-24.569 9.372-33.942 0-9.372-9.373-9.372-24.569 0-33.942L222.059 256 71.029 104.971c-9.372-9.373-9.372-24.569 0-33.942z” /></svg></span>
October 25, 2022 at 2:14 am #2385126David
StaffCustomer SupportAwesome – let us know wha ED have to say. If they are happy with that, then we can start reviewing what we need to do in the Theme 🙂
October 25, 2022 at 3:42 am #2385205Karen
Here’s what she said and this may have been for your code before this last update:
Mark it as “global ignore”. The reason is because he has added:
<a aria-label="Open Search Bar" role="button" href="#">We’re modifying our rule for broken skip and anchor link to ignore links like this when role=”button” has been added. That will come in a future release of Accessibility Checker. For now ignoring the issue is fine.
October 25, 2022 at 3:58 am #2385237David
StaffCustomer SupportThats great, so it looks like for now, the solution i added to your site is good to go.
We will be working on the changes for the theme now.
Let me know if anything else is neededOctober 25, 2022 at 4:14 am #2385253Karen
Great, will do. And thank you!
You saw the GitHub link above too?
October 25, 2022 at 4:24 am #2385258David
StaffCustomer SupportYeah, I am subscribed to that GitHub topic.
For reference:
https://github.com/tomusborne/generatepress/issues/430October 25, 2022 at 4:25 am #2385259Karen
👍🙏
-
AuthorPosts
- You must be logged in to reply to this topic.