- This topic has 30 replies, 2 voices, and was last updated 8 years, 10 months ago by
Tom.
-
AuthorPosts
-
October 14, 2015 at 12:30 am #144195
Peter Islin Nielsen
Yep, I’ve just sent you the login credentials. Knock yourself out π
October 15, 2015 at 3:46 pm #144718Tom
Lead DeveloperLead DeveloperThis is definitely a head scratcher.. I may have something to do with us using the :active or :focus CSS selectors, but if that’s the case, that’s something VC would have to look into, as those are just default CSS selectors and they work when not in the VC rows.
Another possible solution is to do something like this:
<script> var device = navigator.userAgent.toLowerCase(); var ios = device.match(/(iphone|ipod|ipad)/); if ( ios ) { $('.vc_row a') .live('touchstart', function(){ isScrolling = false; }) .live('touchmove', function(e){ isScrolling = true; }) .live('touchend', function(e){ if( !isScrolling ) { window.location = $(this).attr('href'); } }); } </script>
October 16, 2015 at 1:46 am #144792Peter Islin Nielsen
Yeah, it’s super weird. I’ve tried with your suggested code, but it doesn’t help. But I think I’ve found something: After debugging like hell, I’ve narrowed (part of) the issue down to this little code snippet:
/** * Display the classes for the sidebar. * * @since 0.1 * @param string|array $class One or more classes to add to the class list. */ function generate_right_sidebar_class( $class = '' ) { // Separates classes with a single space, collates classes for post DIV echo 'class="' . join( ' ', generate_get_right_sidebar_class( $class ) ) . '"'; }
I don’t know why, but if I remove this code from generatepress/inc/element-classes.php the issue seems to go away on some pages. Of course this not a useful solution because it provokes other errors, but maybe it can give you a hint in what direction to look. I don’t think it’s related to the sidebar β but it might be related to the way classes are handled.
October 16, 2015 at 9:54 am #144890Tom
Lead DeveloperLead DeveloperInteresting – so what happens if you set the page to have no sidebars?
October 16, 2015 at 11:11 am #144904Peter Islin Nielsen
It seems to work when I try it on this page:
http://essens.info/dev/om-essens/But it doesn’t work on this one:
http://inges-kattehjem.dk.linux84.wannafindserver.dk/vores-sag/And it doesn’t work on the front pages (with no sidebars) either.
October 16, 2015 at 11:16 pm #145076Tom
Lead DeveloperLead DeveloperSuper weird – this means it’s probably not that function.
I’ll keep looking into it π
October 25, 2015 at 1:03 pm #147488Peter Islin Nielsen
Hi Tom,
Found anything yet? π
October 26, 2015 at 12:21 am #147597Tom
Lead DeveloperLead DeveloperEvery time I think I get close it doesn’t end up being the issue.
Will dedicate a couple hours tomorrow and get it figured out – will update you.
October 26, 2015 at 1:08 am #147606Peter Islin Nielsen
Thanks, Tom! I really appreciate it.
October 26, 2015 at 10:59 am #147737Tom
Lead DeveloperLead DeveloperAs far as I can tell, it’s an issue with the :hover selector in CSS. If you search for “ios :hover double tap” you’ll find a lot of people talking about it.
Why is it an issue only in VC? I have no idea..
I can’t fully test this (by removing the :hover selectors) as the admin account you made for me can’t access files.
October 26, 2015 at 2:00 pm #147769Tom
Lead DeveloperLead DeveloperIs the homepage of your dev site using VC? I’m not noticing the issue on that page with my iPad.
October 27, 2015 at 1:21 am #147878Peter Islin Nielsen
Yes, it is. Sometimes the issue disappears if there’s no sidebars on the page.
I’ll happily set up an FTP account for you if it can help in any way?
October 27, 2015 at 10:49 am #148011Tom
Lead DeveloperLead DeveloperThat would definitely help – you can send the details to support@generatepress.com π
October 28, 2015 at 2:38 am #148176Peter Islin Nielsen
Done π
April 15, 2016 at 9:31 am #187083Peter Islin Nielsen
Hi Tom.
Just to let you know, this issue has somehow fixed itself. I don’t know how or when, but it was probably in one of the recent updates from WPBakery β maybe the one fixing their jQuery fuckup π
Thanks for all your help!
-
AuthorPosts
- You must be logged in to reply to this topic.