- This topic has 22 replies, 4 voices, and was last updated 1 year, 10 months ago by Tom.
May 27, 2019 at 11:54 pm #912834Enrico
I have tested GeneratePress 2.3 alpha 1 on a little site.
Apparently it work, but when I do an audit with google chrome developer tool I get this error:
Browser errors were logged to the console
Errors logged to the console indicate unresolved problems. They can come from network request failures and other browser concerns.
TypeError: Cannot read property ‘length’ of undefined at /wp-content/themes/generatepress/js/a11y.min.js?ver=2.3-alpha.1:1:1327 at /wp-content/themes/generatepress/js/a11y.min.js?ver=2.3-alpha.1:1:2108May 28, 2019 at 12:53 am #912880Enrico
I was wrong the problem is not in Combine CSS, I removed combine CSS and the error is still there.
So it is a general problem of GeneratePress 2.3 alpha 1May 28, 2019 at 4:08 am #913061DavidStaffCustomer SupportMay 28, 2019 at 4:38 am #913084Enrico
I have done it in incognito mode with Chrome 74.0.3729.169 ( 64 bits) and with Chrome Canary, same error.
On other sites without the alpha 1 version I have not this problem.
I use Windows 10 version 1903 build 18362.145May 28, 2019 at 6:00 am #913141DavidStaffCustomer SupportMay 28, 2019 at 7:48 am #913402Enrico
Sorry, I don’t have a different network, but I have installed again the released version 2.2.2 and the error immediately disappeared.
Then I installed again the alpha-1 and the problem is back again under best practices.May 28, 2019 at 3:43 pm #913795TomLead DeveloperLead DeveloperMay 29, 2019 at 8:40 am #914519TomLead DeveloperLead Developer
If you want to test it, you can replace your
a11y.min.jsfile with the new one: https://raw.githubusercontent.com/tomusborne/generatepress/release/2.3/js/a11y.min.js
Let me know 🙂May 29, 2019 at 8:51 am #914532Enrico
I trust you 🙂 I will wait for the alfa.2.
Thanks a lot
EnricoMay 29, 2019 at 2:01 pm #914781TomLead DeveloperLead DeveloperMay 29, 2019 at 11:55 pm #915007Enrico
the problem is solved with alpha.2
I tested alpha.2 on a different site, you can go to the site from the blog link.
The site don’t use sections, and, doing an audit, I found a new error, again under Best practices.
Does not use passive listeners to improve scrolling performance:
Consider marking your touch and wheel event listeners as
passiveto improve your page’s scroll performance. Learn more.
I tested also the new svg icon and the search svg is too little, it could be because I already use svg in my menus. But I don’t know how to set only the search svg size.May 30, 2019 at 8:46 am #915484TomLead DeveloperLead Developer
I’m not sure if we’ll be able to set it to
passivedue to browser compatibility, but I’ll look into it.
As for the SVG, can I see the issue on your website maybe?May 30, 2019 at 9:33 am #915533Enrico
OK, don’t worry.
I have made some test and I was wrong, the search SVG size is not set by my CSS for my SVG in the menu.
In fact, the search SVG is not smaller, it is only thinner.
For me it is ok.May 30, 2019 at 12:52 pm #915689TomLead DeveloperLead DeveloperJune 2, 2019 at 9:41 am #917870Longinos
Passive event listeners are supported by a widely range of browser and Big G penalize sites that don´t use it. all most in pagespeed insigth.
- You must be logged in to reply to this topic.