- This topic has 16 replies, 3 voices, and was last updated 4 years, 4 months ago by Leo.
-
AuthorPosts
-
November 20, 2019 at 9:37 am #1068761Mark
Since WP 5.3 no more caption field for Gutenberg Gallery block. I have the latest versions of theme and premium. Caption field is working on WP default theme.
November 20, 2019 at 9:52 am #1068776TomLead DeveloperLead DeveloperHi there,
The captions in the editor seem to be working for me: http://prntscr.com/pzpn65
However, in 5.3, WordPress moved the frontend CSS for captions into their optional stylesheet, which you can add to your site like this: https://generatepress.com/forums/topic/caption-styling-broken-after-update-to-wordpress-5-3/#post-1063589
November 20, 2019 at 10:20 am #1068823MarkFunction did not help. I am able to enter captions by scrolling to the bottom of gallery and clicking on “Media Library” and then “Edit Gallery”. Bypassing the gallery block. Captions display fine in the front end I just can’t enter them using the Gutenberg gallery block using the GP theme. Works as expected using the Twenty Twenty theme as seen below.
November 20, 2019 at 12:24 pm #1069033MarkOk, when I comment out position: absolute; on line 91 of
wordpress/wp-content/themes/generatepress/css/admin/block-editor.css all is good. Not sure if this will mess with anything else.November 20, 2019 at 2:00 pm #1069191TomLead DeveloperLead DeveloperThat’s strange, as WordPress itself adds
position: absolute
to the same element: http://prntscr.com/pzswxxThe top one is in GP, and the bottom one is Gutenberg.
I’m not experiencing any issues editing the caption inline: http://prntscr.com/pzsx7d
Have you tried deactivating your other plugins to see if there’s a conflict somewhere?
November 20, 2019 at 3:38 pm #1069325MarkI’ve deactivated all my plugins but still the same result. If things are working for you on 5.3 there there must be something going on my end. I’ll do some more digging and let you know what I find. Thank your patience.
November 20, 2019 at 5:28 pm #1069415TomLead DeveloperLead DeveloperSuper strange – feel free to send me temporary admin login details if you’d like – that will allow me to take a closer look: https://generatepress.com/contact
Just be sure to mention this topic π
November 20, 2019 at 6:42 pm #1069480MarkUnfortunately I’m developing locally using XAMPP so I can’t send you a login. Here is what I have discovered if it helps.
After upgrading to WP 5.3 I get this. No Caption
If I delete line 91 position: absolute; from generatepress/css/admin/block-editor.css I get this…
If I delete the selector .editor-block-list__layout from generatepress/css/admin/block-editor.css line 90 I get this, looks like the default backend style…
November 21, 2019 at 9:10 am #1071016TomLead DeveloperLead DeveloperDo you have another site you can test on? Wondering if it’s something specific to that install.
November 21, 2019 at 5:07 pm #1071616MarkHi Tom, I upgraded a clients site to WP 5.3 and the same thing happened, gallery caption field is missing. From what I have read it looks like 5.3 blocks can cause all kinds of difficulties for theme developers. It’s not ideal but here is my dirty solution that gives me exactly what I need…
Delete the selector .editor-block-list__layout from generatepress/css/admin/block-editor.css line 90 and add the following to custom CSS
.wp-block-gallery .blocks-gallery-image figcaption, .wp-block-gallery .blocks-gallery-item figcaption {
background:linear-gradient(0deg,rgba(0,0,0,.7),rgba(0,0,0,.6) 70%,transparent);
color: #fff;
padding: 2px 10px 0px;;
box-sizing: border-box;
font-size: 16px;
}November 22, 2019 at 8:38 am #1072794TomLead DeveloperLead Developer5.3 definitely had some changes when it comes to themes, but I’m not seeing this issue no matter where I look. I’ll check with our other team members to see if they can see the issue.
Will let you know π
November 22, 2019 at 11:38 am #1073013MarkThat would be great! I just downloaded WP 5.3 directly from the WP site and did a clean install to my local machine with no added plugins and the latest GP theme and captions work fine on default twenty twenty theme but not on GP theme. I sincerely apologize if this turns out to be something on my end but damn if I can figure it out. Tried different browsers, php is up to date.
Thanks
November 22, 2019 at 4:52 pm #1073231TomLead DeveloperLead DeveloperI just checked with David and he’s not noticing the issue either.
Is there any way you can set up a live test site where I can see the issue? If I’m able to inspect the issue first hand, I should be able to spot the problem and fix it π
Thank you!
November 23, 2019 at 11:44 am #1074130MarkHi Tom, Live test site is set up and ready for your inspection. Let me know where to email the login info.
Thanks
November 23, 2019 at 12:05 pm #1074141TomLead DeveloperLead DeveloperAwesome! You can send it through the form here: https://generatepress.com/contact/
Thank you π
-
AuthorPosts
- You must be logged in to reply to this topic.