Archived topic
Video format/aspect ratio in bbpress
12 replies · Started by Jim on February 5, 2018
If I post a video in a bbpress message the format/aspect ratio is not what it should be.
The video frame is much higher and that looks kinda ugly...
Have a look, that explains better what I mean:
https://cl.ly/1O1E3h0B2O2r
Hope to hear from you if this can be solved.
Thanks,
Jim
Hi there,
Have you checked in BBPress on this issue?
Let me know.
Well I just switched to your theme, so I suppose the problem is caused by the generatepress theme.
I didn't have this problem before.
Just checked the link you've provided but don't see a video?
Can you try this method here? https://generatepress.com/forums/topic/lightweight-grid-columns-youtube-height-values-not-set-automatically/#post-455249
Works great!
Is it possible to embed this into an update of the theme?
I am not working with a child theme so I had to paste this into the functions file of the generatepress theme, which will be overridden by an update.
Or is there another way to add functions to the theme?
I've always liked Code Snippet: https://docs.generatepress.com/article/adding-php/#code-snippets
Should never edit the theme's core files :)
Exactly, that's why I ask.
Why not put it into the theme then?
I'll check with Tom :)
Anything that modifies your content should be done via a plugin or custom snippet. Otherwise your content will lost formatting if you ever decide to switch themes, which is no fun.
I agree with you here Tom.
But in my opinion this does not modify content but fix a problem that I didn't have with other themes.
Your point is what Tom was trying to say.
The other theme obviously had something like this added to their code which isn't transferable and that's not good, because when you switch themes and function is lost.
If you tested with a twenty series themes from WordPress, the videos shouldn't be responsive either.
