- This topic has 12 replies, 3 voices, and was last updated 3 years, 3 months ago by Leo.
February 5, 2018 at 1:08 am #488166Jim
If I post a video in a bbpress message the format/aspect ratio is not what it should be.
The video frame is much higher and that looks kinda ugly…
Have a look, that explains better what I mean:
Hope to hear from you if this can be solved.
JimGP Premium 1.5.6February 5, 2018 at 8:20 am #488497LeoStaffCustomer SupportFebruary 5, 2018 at 9:25 am #488580Jim
Well I just switched to your theme, so I suppose the problem is caused by the generatepress theme.
I didn’t have this problem before.February 5, 2018 at 10:53 am #488652LeoStaffCustomer SupportFebruary 6, 2018 at 2:11 am #489203JimFebruary 6, 2018 at 8:28 am #489550LeoStaffCustomer Support
Can you try this method here? https://generatepress.com/forums/topic/lightweight-grid-columns-youtube-height-values-not-set-automatically/#post-455249February 6, 2018 at 9:28 am #489659Jim
Is it possible to embed this into an update of the theme?
I am not working with a child theme so I had to paste this into the functions file of the generatepress theme, which will be overridden by an update.
Or is there another way to add functions to the theme?February 6, 2018 at 9:43 am #489671LeoStaffCustomer Support
I’ve always liked Code Snippet: https://docs.generatepress.com/article/adding-php/#code-snippets
Should never edit the theme’s core files 🙂February 6, 2018 at 11:58 am #489781Jim
Exactly, that’s why I ask.
Why not put it into the theme then?February 6, 2018 at 5:14 pm #489969LeoStaffCustomer SupportFebruary 6, 2018 at 9:47 pm #490104TomLead DeveloperLead Developer
Anything that modifies your content should be done via a plugin or custom snippet. Otherwise your content will lost formatting if you ever decide to switch themes, which is no fun.February 6, 2018 at 11:44 pm #490141Jim
I agree with you here Tom.
But in my opinion this does not modify content but fix a problem that I didn’t have with other themes.February 7, 2018 at 8:59 am #490560LeoStaffCustomer Support
Your point is what Tom was trying to say.
The other theme obviously had something like this added to their code which isn’t transferable and that’s not good, because when you switch themes and function is lost.
If you tested with a twenty series themes from WordPress, the videos shouldn’t be responsive either.
- You must be logged in to reply to this topic.