[Resolved] The type attribute

[Maarten]

Tom, when I do all the above and make my selections. I did the following test:

1) Build site
2) Load GP Premium Plugin (Only)
3) Child Theme Loaded
4) Activate all options in GP Premium (All check-mark)
5) Make Menu named Main -> Add only Home and Blog to menu -> Save menu
6) Menu Locations -> Select Main for Primary and Off Canvas locations and Save locations
7) Visit site
8) Edit the created article in Gutenberg Classic Editor (Build in)

(Will open classic editor by Gutenberg it self because my WP Builder just adds a article to wp_posts and as you may know it this is pure HTML code and no wp_block or how it is called by Gutenberg)

(I could transform it to Gutenberg Block but left it with build in classic editor)

9) The reason for editing is to have the plugin somehow ‘feel’ the document is active and new (No idea if this has any effect)

10) Make edits and publish the article

11) Open customizer and remove all options/checkmarkt for single post
12) Save settings

13) Check article, yes all extra’s are gone and only Headline is visible

(One more tip for future version of GP Premium would be to have the typography option and text-transform to have H1/Headline/H2-H6, [Center Text] as option in customizer)

That would be great because it is used a lot for sales pages and having H1 be centered without extra CSS is again a speed improvement.

14) Go back to backend in WP and into GP Premium and now backup all to JSON (Selected all options to export)

-> Here the problem is. When I now build the exact same website and import that JSON it will not reflect the customizer options under single blog post, it will just be back to checked state again.

-> Remember – All other options work perfect and revert to the state from the JSON Import, just not in my situation the blog and single post check-mark options in customizer.

So, at this part I did something different, how about just resetting all options in GP Premium, let’s do that

15) In GP-Premium press -> Reset all settings
16) Check homepage and article and yes author, date and category link are back below the title of the article, just as we would expect it to be

Now the interesting part.

17) Go back into WP Backend and to GP-Premium settings and just Import the JSON I made that should not checkmark the options in customizer under blog section for a single post

18) Load settings and press Import

19) Settings reloaded, let’s check the homepage and the article again

Guess what?

20) The options are in place! The article has just my headline and body text and no author, tags, category link etc are visible

Conclusion:

When I build a new site and import JSON, it somehow does not set the options in customizer for a single blog options/check-marks

When I do a hard reset inside backend of WP for the GP-Premium settings and THEN Import the JSON with my settings, it does reflect the correct options.

Remember, I did this test just removing all single blog post options/check-marks in Customizer and no other settings.

Hope this helps.

Edit: -> It feels like it has to do with initializing the plugin. My Builder just unpacks the zip and does nothing extra than that, it should be the same doing it by hand and selecting the plugin WordPress plugins Add new.

-> When I press to reset the settings after the plugin has been loaded and the Import it seems to solve my problem and loads the single blog options in customizer however it still is strange but this does seem to have effect

-> I can not find what Reset Settings does in MySQL but something is fixing the problem I seem to have

-> Of course I can just not have my builder add any plugins and do it by hand with add plugin option in WordPress, maybe that does work better however that would be weird as I do not auto activate any plugin using my builder and always have dashboard loaded after login

P.s. Have a look at my bold text for GP Premium in this post, I hope you could make a note and maybe consider to implement it in a future version

[Tom]

Thanks for all of this! I’ll do some additional tests to see if it’s something we can improve upon – sounds like there may just be some basic logic missing from the importer.

Appreciate the suggestion as well – I agree that this would be useful 🙂

[Maarten]

Hi Tom, I will do some more tests like:

Double import. 1 X Import and activate than wait 3 seconds and do the same again.

Until now only reset settings is working after Import and re-import JSON again.

Will let you know if I find something important.

Yes, please add a option to have underlined links on hover. Just like Google’s page. People are used to blue links and underlined on hover (see google) get’s higher conversion.

Here is my CSS:

.inside-article p a:hover,
.inside-article p a:active,
.inside-article p a:visited {
text-decoration: underline;
}

.widget a:hover,
.widget a:active,
.widget a:visited {
text-decoration: underline;
}

For category desc/tax/etc

.taxonomy-description p a:hover,
.taxonomy-description p a:active,
.taxonomy-description p a:visited {
text-decoration: underline;
}

.site-footer a:hover,
.site-footer a:active,
.site-footer a:visited {
text-decoration: underline;
}

Do the same for Headings H1-H6 but more important add a option to < Center > the Heading text (Useful for sale pages and just looks very nice on mobile as well)

My CSS:

.single-post .entry-header {
text-align: center;
}

Final:

Have all active sidebars be able to below content on iPad and Mobile. I know it will do it on mobile as the space is to small/narrow but not 100% sure it will do it on iPad’s.
Having a option to have a sidebar with opt-in or sale offer below the content also looks great (But maybe this already is done no idea)

Also it is nice to have bullet-points be shown in widgets:

.widget ul {
margin: 0 0 1.5em 3em;
}

.widget ul li {
list-style-type: disc;
}

And if possible add a line below header, so we can keep it white but have a line to separate to body content visually.

Here is my CSS for that:

.site-header, #mobile-header {
border-bottom: 2px solid #efefef;
}

Now when you scroll you will see a line 2px solid grey color… so you can see the header good and if white does not blend in with body content specially when header is sticky.

Thanks for your great work, will always advice anyone to buy your plugin and I will do that forever : )

Regards.

[Tom]

Thanks, Maarten! Will absolutely take all of this into consideration. Really appreciate it 🙂

[Maarten]

You are welcome Tom,

And if you also while working on premium add an option to have the whole menu be next to the logo/site-name, just like some Google sites layout. Some users like it a lot, it has the logo and then the menu 100% next to it (right side) with some space and then menu items. It can look very nice.

.nav-float-right .inside-header .main-navigation {
float: none;
display: inline-block;
vertical-align: middle;
}
.main-navigation .main-nav ul li a {
margin-left: 45px;
}

Hope this helps and gives you some good ideas for the future version.

If I find something important about import export, I will let you know.

Have a great weekend.

P.S If you do implement these things, I will not have to use a child theme anymore as these are all in my child theme CSS, except the one in this reply – that is just to keep a note for moving the whole menu item section next to the menu on the same line : )

[Tom]

Our navigation as header option may be worth checking out: https://docs.generatepress.com/article/navigation-as-a-header/

[Maarten]

Thanks Tom, I did not even see that document. I might be better using that and not add extra CSS for styling than. This is great thanks.

I have done some more tests:

=> Double Import of JSON file seems to fix my weird problem.

First import -> Blog items in customizer for post/page are checked but should be un-checked

Second Import of the same JSON -> Blog items in customizer are now like they were when I made a export, they are all unchecked so only my title is visible.

I cannot debug this any further as I am not a Pro PHP developer but just hobby. I do know some things about my database and JSON and some PHP but this is getting to hard to debug.

It does seem like it not taking in all values and a second time it does.

Maybe this does not happen on a real live domain and only on my localhost.

Anyway, no problem to import it 2 times as that does fix all issues.

Thanks for your support in this topic.

Regards.

[Tom]

That’s interesting, thanks for reporting back. I’ve tested this a few times and haven’t noticed any issues so far – I’ll definitely keep an eye on it, and feel free to report back if anything else comes up.

Thank you!

[Maarten]

I will make a new post if really needed but thanks so far.

Also GP 3 is very very nice but cannot move the logo (center or right side of menu) using GP premium latest version. I will make a new post for it later and will close this one.

Have a great day.

[Maarten]

The ‘type=’ about this topic has been resolved and code is not needed anymore as Tom has put it inside the best Theme ever called GeneratePress 3.0 !

[Maarten]

Dear Tom,

I have run some more debugging and when I upload the JSON file and then also a second time to get blog settings in the database for single page/post from customizer, this is reported in debug log:

[21-Oct-2020 21:06:36 UTC] PHP Notice: Only variables should be passed by reference in D:\Xampp\htdocs\site.local\wp-content\plugins\gp-premium\import-export\functions\functions.php on line 239

[21-Oct-2020 21:06:46 UTC] PHP Notice: Only variables should be passed by reference in D:\Xampp\htdocs\site.local\wp-content\plugins\gp-premium\import-export\functions\functions.php on line 239

See the time? 21:06:36 UTC and 21:06:46 UTC, In this time I did 2 times upload and Import of the same settings file.

No idea if this helps?

Best Regards.

[Maarten]

Hi, is it better to make a new topic to follow up on this or is this place ok for it?

Thanks

[Tom]

Hmm, hard to tell by those logs. Can you email us the exported file that you’re importing?

[Maarten]

Hi Tom,

Yes, I will send you the JSON file.

Thanks.

[Author]

Posts