Black Friday Sale! Get up to $40 off GP Premium!Learn more

[Resolved] RTL Issue after last update

Home Forums Support RTL Issue after last update

Viewing 13 posts - 1 through 13 (of 13 total)
  • Author
    Posts
  • #446160
    Guy

    Hi There.
    So I am using your the quite a lot 🙂
    I think it’s the greatest theme I have used all my life…
    In general there are issues when using ltr themes in rtl websites.
    especially when using wpbakery visual composer.
    The main issue is with full width rows.
    To make a workaround it – I put a script on each theme I am using –

    jQuery(window).load(function( $ ){
       if( jQuery('html').attr('dir') == 'rtl' ){
            jQuery('[data-vc-full-width="true"]').each( function(i,v){
                jQuery(this).css('right' , jQuery(this).css('left') ).css( 'left' , 'auto');
            });
        } 
    });
    
    

    This is true to all of the themes I am using -it has to do with the alignment of the row to the left and some calculations it is doing.

    Now…

    After your update this script seems to work only if I install revolution slider and activate it, regardless if it is present on the page. ( this is after lots of tests from me )

    So…

    Maybe you will be able to make a patch for it and fix the theme so I don’t have to use this script each time and also to make it work without the rev slider?

    These are the credentials of the demo I created for you to see it and test it.
    You can destroy whatever you need there.

    http://80.179.60.44/~generate/wp-admin

    Some of the web sites I built with your theme –

    http://80.179.140.91/~masik/
    http://80.179.140.91/~condor/
    http://fedorica.com/
    fedorasecurity.com/
    http://www.gushpanka.co.il

    and there are many more…

    If you need my help, I can help in every way I can.

    Thanks!!!!
    Guy

    GeneratePress 2.0
    GP Premium 1.5.6
    #446210
    Guy

    Just to clarify – The script I put is to fix the alignment of full width rows in rtl web sites only.
    It works in generate 2.0 only if I activate revolution slider.
    It will be great If I didn;t have to include this script at all if you create an update in your theme.
    Thanks!
    Guy

    #446222
    Guy

    Let’s work on this website –

    http://80.179.140.91/~press/wp-admin

    #446224
    Guy

    I made a homepage with 2 rows – one with revolution slider and one with a simple full width row with bg image.

    Sorry for flooding….

    http://80.179.140.91/~press/

    #446337
    Tom
    Lead Developer
    Lead Developer

    Hi there,

    I’m not too sure what that script does – the text should be RTL if you’re using an RTL language.

    Instead of using VC to force full width pages, try using the Page Builder Container option: https://docs.generatepress.com/article/page-builder-container/

    #446727
    Guy

    Hi Tom.
    In visual composer you can have some of the rows span full width.
    So not all the layout is full-width.
    Only the rows you specify.
    Without this script – the rows that are full width – they are not aligned right.
    So this script helps them to align properly.
    you can test it yourself on the demo site I created – just disable the plugin or script
    Currently – If I don’t install revolution slider – it doesn’t work.
    I would gladly share my screen with you and explain.

    You solution forces all rows to be full width which is not the right solution most of the times…
    Thanks!
    Guy

    #447160
    Tom
    Lead Developer
    Lead Developer

    The Page Builder Container solution does force everything to be full width. However, you should be able to define a contained container within your VC settings.

    So this setting tells the theme to remove the contained container, which then allows the page builder to define whether each row is full width or contained.

    Using jQuery for something like this is likely overkill. By default jQuery isn’t loaded in the theme, but will load if Rev slider is in use. That’s likely why it’s not working.

    #447188
    Guy

    Now I setup the page like that –
    fullwidth and added a normal row without setting it to full width.
    I disabled the script I wrote.
    http://80.179.140.91/~press/
    Everything looks wrong.
    The normal contained row is set to full width because there are no setting for it in visual composer.
    and there is a strange gap on the whole of the page to the left and the full width rows + revolution slider are not aligned.

    I’m sorry to be a pain in the ass….
    It’s just that your theme is so great and i DO USE IT QUITE A LOT….

    #447274
    Tom
    Lead Developer
    Lead Developer

    Hmm, not sure what’s supposed to make that contained row contained – there’s no code telling it to be.

    You can use your jQuery like this:

    add_action( 'wp_enqueue_scripts', 'tu_manually_add_jquery' );
    function tu_manually_add_jquery() {
        wp_enqueue_script( 'jquery' );
    }
    #447459
    Guy

    So that’s the issue 🙂
    You cannot have both fullwidth rows and contained rows at the same time with visual composer without the script I put there 🙂
    But maybe it’s too specific to Hebrew and Arabic. (rtl lang)
    Not sure how many rtl clients are using your theme…
    Thanks!

    #447471
    Tom
    Lead Developer
    Lead Developer

    Very strange indeed. Did the code fix the issue for you?

    #447560
    Guy

    Yeah!
    Thanks!
    One day we will work on this together so i will be able to explain a little better what the issue is.
    Thanks!
    Guy

    #447871
    Tom
    Lead Developer
    Lead Developer
Viewing 13 posts - 1 through 13 (of 13 total)
  • You must be logged in to reply to this topic.