- This topic has 35 replies, 5 voices, and was last updated 4 years ago by Suraj Katwal.
-
AuthorPosts
-
February 4, 2020 at 10:40 am #1154485Abdelhakim
FIX THIS PLEASE!!!
February 4, 2020 at 10:51 am #1154495TomLead DeveloperLead DeveloperThanks for the video – very useful. It confirms that the incompatibility is with the smooth scroll library itself. They can run the same test in the console on their demo (no GP at all): https://codepen.io/cferdinandi/pen/wQzrdM
As I pointed out before (https://generatepress.com/forums/topic/problem-with-smooth-scroll-and-luckywp-plugin/#post-1153506), they may want to report this to the author of the library, as it’s super popular and used on a lot of websites.
I know having two developers send you back and forth is frustrating – I’m sorry about that. However, there isn’t much we can do about it on our end at this time. The smooth scroll library is great, as it’s vanilla JS and works really nicely. It’s not something we’ll be removing from GP because of this specific issue.
If they’re able to report the issue to the developers, perhaps they’ll fix it. If they do, we’ll absolutely update the code in our plugin.
February 5, 2020 at 6:57 am #1155518AbdelhakimHello Tom, check the last replay of LuckyWP’s developer, he mentioned important things that may help you solve this issue.
February 5, 2020 at 11:13 am #1155794AbdelhakimHello tom, No! I did the change needed and put gpscroll in the right place, still the same problem
February 5, 2020 at 11:32 am #1155817TomLead DeveloperLead DeveloperHere’s your file: https://www.luca.eu/wp-content/plugins/gp-premium/general/js/smooth-scroll.min.js?ver=1.9.1
Go there and ctrl + F:
var scroll
When the file is updated to the below version, it will be:
var gpscroll
February 5, 2020 at 11:39 am #1155826AbdelhakimLOl, i am not the owner of this website as i told you before i did everything you said. Check this one and you will see that i did the changes…. https://www.topjardin.fr/desherber-une-grande-surface/
February 5, 2020 at 11:42 am #1155835TomLead DeveloperLead DeveloperCan you turn off the caching plugin for a moment?
As of right now, it’s not showing the change: https://www.topjardin.fr/wp-content/plugins/gp-premium/general/js/smooth-scroll.min.js
However, it may be cached.
February 5, 2020 at 12:31 pm #1155887AbdelhakimGreat, it works when I turned off SG Optimizer (caching plugin). But i dont want to keep the plugin off…What should i do?
February 5, 2020 at 12:33 pm #1155888TomLead DeveloperLead DeveloperTry clearing the cache using the plugin options once it’s turned back on.
February 5, 2020 at 12:47 pm #1155895AbdelhakimNot working ๐
February 5, 2020 at 12:55 pm #1155907TomLead DeveloperLead DeveloperIt’s not releasing the cache, I guess? At least we know the fix in the file works – I’ve made that change so it will be a part of our next update.
As for the cache, I’m not really sure.. If you empty the cache inside the plugin, it should force it to re-generate the file. I’ve never used that specific caching plugin – perhaps there are multiple things you need to clear?
February 5, 2020 at 3:00 pm #1155994AbdelhakimWell, i give up tom, I will be forced to change the table of the content plugin for another one in all my 10 websites. Should i replace the gpscroll to scroll ( default ) or it doesn’t matter i can leave it gpscroll?
February 5, 2020 at 5:35 pm #1156092TomLead DeveloperLead DeveloperThat’s a shame – it seems like we found a fix, your cache was just holding on. I would maybe suggest trying a different caching plugin, as it’s going to cause other issues for you if it won’t clear.
If you’re going to switch plugins, you can just leave the change we made to the plugin – it won’t do any harm.
February 5, 2020 at 5:42 pm #1156093AbdelhakimEverything is working fine now, i don’t know what was the cause exactly, i purged the cache i deactivated the plugin everything…But it’s working no. Thank god.
I will face this kind of problem in the future?
February 5, 2020 at 5:47 pm #1156095TomLead DeveloperLead DeveloperGreat news! No, we’ve committed this change so it will be in the next version of the plugin automatically ๐
-
AuthorPosts
- You must be logged in to reply to this topic.