[Resolved] Problem with smooth-scroll and LuckyWP plugin

Home Forums Support [Resolved] Problem with smooth-scroll and LuckyWP plugin

Home Forums Support Problem with smooth-scroll and LuckyWP plugin

  • This topic has 35 replies, 5 voices, and was last updated 4 years ago by Suraj Katwal.
Viewing 15 posts - 16 through 30 (of 36 total)
  • Author
    Posts
  • #1154485
    Abdelhakim

    I am upset aswell

    FIX THIS PLEASE!!!

    #1154495
    Tom
    Lead Developer
    Lead Developer

    Thanks for the video – very useful. It confirms that the incompatibility is with the smooth scroll library itself. They can run the same test in the console on their demo (no GP at all): https://codepen.io/cferdinandi/pen/wQzrdM

    As I pointed out before (https://generatepress.com/forums/topic/problem-with-smooth-scroll-and-luckywp-plugin/#post-1153506), they may want to report this to the author of the library, as it’s super popular and used on a lot of websites.

    I know having two developers send you back and forth is frustrating – I’m sorry about that. However, there isn’t much we can do about it on our end at this time. The smooth scroll library is great, as it’s vanilla JS and works really nicely. It’s not something we’ll be removing from GP because of this specific issue.

    If they’re able to report the issue to the developers, perhaps they’ll fix it. If they do, we’ll absolutely update the code in our plugin.

    #1155518
    Abdelhakim

    Hello Tom, check the last replay of LuckyWP’s developer, he mentioned important things that may help you solve this issue.

    #1155794
    Abdelhakim

    Hello tom, No! I did the change needed and put gpscroll in the right place, still the same problem

    #1155817
    Tom
    Lead Developer
    Lead Developer

    Here’s your file: https://www.luca.eu/wp-content/plugins/gp-premium/general/js/smooth-scroll.min.js?ver=1.9.1

    Go there and ctrl + F: var scroll

    When the file is updated to the below version, it will be: var gpscroll

    https://pastebin.com/USymFcuZ

    #1155826
    Abdelhakim

    LOl, i am not the owner of this website as i told you before i did everything you said. Check this one and you will see that i did the changes…. https://www.topjardin.fr/desherber-une-grande-surface/

    #1155835
    Tom
    Lead Developer
    Lead Developer

    Can you turn off the caching plugin for a moment?

    As of right now, it’s not showing the change: https://www.topjardin.fr/wp-content/plugins/gp-premium/general/js/smooth-scroll.min.js

    However, it may be cached.

    #1155887
    Abdelhakim

    Great, it works when I turned off SG Optimizer (caching plugin). But i dont want to keep the plugin off…What should i do?

    #1155888
    Tom
    Lead Developer
    Lead Developer

    Try clearing the cache using the plugin options once it’s turned back on.

    #1155895
    Abdelhakim

    Not working ๐Ÿ™

    #1155907
    Tom
    Lead Developer
    Lead Developer

    It’s not releasing the cache, I guess? At least we know the fix in the file works – I’ve made that change so it will be a part of our next update.

    As for the cache, I’m not really sure.. If you empty the cache inside the plugin, it should force it to re-generate the file. I’ve never used that specific caching plugin – perhaps there are multiple things you need to clear?

    #1155994
    Abdelhakim

    Well, i give up tom, I will be forced to change the table of the content plugin for another one in all my 10 websites. Should i replace the gpscroll to scroll ( default ) or it doesn’t matter i can leave it gpscroll?

    #1156092
    Tom
    Lead Developer
    Lead Developer

    That’s a shame – it seems like we found a fix, your cache was just holding on. I would maybe suggest trying a different caching plugin, as it’s going to cause other issues for you if it won’t clear.

    If you’re going to switch plugins, you can just leave the change we made to the plugin – it won’t do any harm.

    #1156093
    Abdelhakim

    Everything is working fine now, i don’t know what was the cause exactly, i purged the cache i deactivated the plugin everything…But it’s working no. Thank god.

    I will face this kind of problem in the future?

    #1156095
    Tom
    Lead Developer
    Lead Developer

    Great news! No, we’ve committed this change so it will be in the next version of the plugin automatically ๐Ÿ™‚

Viewing 15 posts - 16 through 30 (of 36 total)
  • You must be logged in to reply to this topic.