[Support request] Potential Bug Report: Page Header Logo Overridden When Mobile Logo Selected

Home Forums Support [Support request] Potential Bug Report: Page Header Logo Overridden When Mobile Logo Selected

Home Forums Support Potential Bug Report: Page Header Logo Overridden When Mobile Logo Selected

Viewing 6 posts - 1 through 6 (of 6 total)
  • Author
    Posts
  • #581331
    Martin

    I use a different logo on a Page Header to make it more visible against the chosen header background. This works great — whenever the page with this Page Header loads, the default logo is overridden by the one chosen in the Page Header settings.

    However, if I upload a Mobile Logo in the customizer (Layout>Header>Mobile Header>On) the logo I chose in Page Header no longer loads on pages where the Page Header is used. Instead, the default logo displays.

    How to replicate:

    1. Upload a default site logo.
    2. Create a Page Header with a different logo.
    3. Load a normal page and see the default site logo.
    4. Load a page that uses the Page Header with a custom logo and see the alternative logo.
    5. Switch on the Mobile Header and upload a mobile logo.
    6. Reload the page with the Page Header with a custom logo and you will see the default logo rather than the custom logo originally chosen.

    GeneratePress 2.1.2
    GP Premium 1.6.2
    #581342
    Tom
    Lead Developer
    Lead Developer

    Thanks for reporting this, really appreciate it! We’ll take a look and will get back to you ASAP.

    #581346
    Martin

    I managed to fix this by renaming the name of the mobile logo and reuploading it again. It seems that something was going wrong in the srcset for the logo. The 1x was fine, but for some reason the 2x was pulling in the wrong logo. By uploading a mobile logo with a different file name, all seems to be working now.

    The source code was something like this:

    <img class="header-image" src="CORRECT FILE PATH" srcset="CORRECT FILE PATH 1x, WRONG FILE PATH 2x" />

    #581348
    Tom
    Lead Developer
    Lead Developer

    Ah yes, we’ll get that fixed in 1.6.3.

    Thanks again!

    #581350
    Martin

    I’m not sure the srcset was the issue after all, having looked at a cached page — but the solution seems to still work (just upload a mobile logo with a different file name).

    #581351
    Tom
    Lead Developer
    Lead Developer

    I know that the srcset issue is a bug we have to fix. I’ll log this so we can take a closer look at it at the same time.

Viewing 6 posts - 1 through 6 (of 6 total)
  • You must be logged in to reply to this topic.