- This topic has 18 replies, 3 voices, and was last updated 5 months, 3 weeks ago by Tom.
December 9, 2019 at 10:19 am #1098971Steven
When the mobile menu is activated on a device where a keyboard, VoiceOver, or Voice Assistant is being used to navigate the site, the overlay doesn’t appear to get the focus. When the menu opens, the focus remains on the underlying page instead of the menu. This makes the menu and close option inaccessible to keyboard/voice assisted users. Can the script that handles opening the off canvas menu be modified to set focus to the overlay? Running GP Premium 1.9.1 on WordPress 5.3.December 9, 2019 at 7:50 pm #1099388TomLead DeveloperLead DeveloperDecember 10, 2019 at 9:10 am #1100076Steven
I disabled the element hook that was injecting the search into the off canvas menu. It still has the focus issue. To reproduce:
Configure a site to use the off canvas for mobile.
Narrow the browser to activate the mobile toggle button.
Select the mobile toggle button using a keyboard and the Enter key.
Try to navigate the primary nav in the off canvas menu with the tab key.
You’ll see it traversing the underlying page until it gets to the bottom of the page and then appears to eventually get to the off canvas menu items.
The desired behavior would be to have the focus set to the off canvas container and have it announced that the menu has been opened.December 10, 2019 at 5:25 pm #1100434TomLead DeveloperLead Developer
That behavior should be happening. For example, check out this site in our library: https://gpsites.co/spacious
I wonder what combination of options is breaking it. I’ll play around to see if I can reproduce it.December 11, 2019 at 8:21 am #1101175Steven
Try Customizing > Layout > Off Canvas Panel > Style = OverlayDecember 15, 2019 at 9:17 am #1105097TomLead DeveloperLead DeveloperDecember 16, 2019 at 8:31 am #1105996Steven
Thanks for the confirmation.February 19, 2020 at 5:02 pm #1170980Naomi
👍👍👍😊 So glad to hear that!February 19, 2020 at 7:38 pm #1171041TomLead DeveloperLead DeveloperFebruary 20, 2020 at 12:42 pm #1171935Naomi
Very exciting! Thank you!April 1, 2020 at 10:47 am #1222485TomLead DeveloperLead Developer
Just a heads up that 1.10.0 is available for testing if you’d like the confirm the fix: https://generatepress.com/gp-premium-1-10-0/
Thanks!April 1, 2020 at 11:08 am #1222522Steven
Not sure if this is fixed. I’ve updated to the Version 1.10.0-alpha.1: https://bhamprod.wpengine.com/April 1, 2020 at 12:00 pm #1222592TomLead DeveloperLead Developer
Strange, it was working but now it’s not.
I think I’ve figured it out now so it will be in beta.1. Would you like to wait until then to find out, or are you comfortable overwriting a file in the plugin to test now?
Let me know 🙂April 1, 2020 at 12:02 pm #1222595Steven
Happy to manually override so we can give you feedback.April 1, 2020 at 12:32 pm #1222632TomLead DeveloperLead Developer
Awesome, thank you!
Replace the contents of the
wp-content/plugins/gp-premium/menu-plus/functions/js/offside.min.jsfile with this: https://pastebin.com/u2hLLfi4
Then you may need to clear your browser cache/do a hard refresh.
- You must be logged in to reply to this topic.