[Support request] Off canvas focus

Home Forums Support [Support request] Off canvas focus

Home Forums Support Off canvas focus

  • This topic has 18 replies, 3 voices, and was last updated 4 years ago by Tom.
Viewing 15 posts - 1 through 15 (of 19 total)
  • Author
    Posts
  • #1098971
    Steven

    When the mobile menu is activated on a device where a keyboard, VoiceOver, or Voice Assistant is being used to navigate the site, the overlay doesn’t appear to get the focus. When the menu opens, the focus remains on the underlying page instead of the menu. This makes the menu and close option inaccessible to keyboard/voice assisted users. Can the script that handles opening the off canvas menu be modified to set focus to the overlay? Running GP Premium 1.9.1 on WordPress 5.3.

    #1099388
    Tom
    Lead Developer
    Lead Developer

    Hi there,

    Strange – it should be accessible. What happens if you temporarily remove the widgets from the panel?

    #1100076
    Steven

    Hi Tom,

    I disabled the element hook that was injecting the search into the off canvas menu. It still has the focus issue. To reproduce:

    Configure a site to use the off canvas for mobile.
    Narrow the browser to activate the mobile toggle button.
    Select the mobile toggle button using a keyboard and the Enter key.
    Try to navigate the primary nav in the off canvas menu with the tab key.
    You’ll see it traversing the underlying page until it gets to the bottom of the page and then appears to eventually get to the off canvas menu items.

    The desired behavior would be to have the focus set to the off canvas container and have it announced that the menu has been opened.

    #1100434
    Tom
    Lead Developer
    Lead Developer

    That behavior should be happening. For example, check out this site in our library: https://gpsites.co/spacious

    I wonder what combination of options is breaking it. I’ll play around to see if I can reproduce it.

    #1101175
    Steven

    Try Customizing > Layout > Off Canvas Panel > Style = Overlay

    #1105097
    Tom
    Lead Developer
    Lead Developer

    Yea, there’s the bug. Thanks for reporting this – will get in fixed in 1.10 πŸ™‚

    #1105996
    Steven

    Thanks for the confirmation.

    #1170980
    Naomi

    πŸ‘πŸ‘πŸ‘πŸ˜Š So glad to hear that!

    #1171041
    Tom
    Lead Developer
    Lead Developer

    This has been fixed in 1.10.0, which will be going into alpha testing shortly πŸ™‚

    #1171935
    Naomi

    Very exciting! Thank you!

    #1222485
    Tom
    Lead Developer
    Lead Developer

    Just a heads up that 1.10.0 is available for testing if you’d like the confirm the fix: https://generatepress.com/gp-premium-1-10-0/

    Thanks!

    #1222522
    Steven

    Not sure if this is fixed. I’ve updated to the Version 1.10.0-alpha.1: https://bhamprod.wpengine.com/

    #1222592
    Tom
    Lead Developer
    Lead Developer

    Strange, it was working but now it’s not.

    I think I’ve figured it out now so it will be in beta.1. Would you like to wait until then to find out, or are you comfortable overwriting a file in the plugin to test now?

    Let me know πŸ™‚

    #1222595
    Steven

    Happy to manually override so we can give you feedback.

    #1222632
    Tom
    Lead Developer
    Lead Developer

    Awesome, thank you!

    Replace the contents of the wp-content/plugins/gp-premium/menu-plus/functions/js/offside.min.js file with this: https://pastebin.com/u2hLLfi4

    Then you may need to clear your browser cache/do a hard refresh.

Viewing 15 posts - 1 through 15 (of 19 total)
  • You must be logged in to reply to this topic.