- This topic has 7 replies, 2 voices, and was last updated 1 year, 9 months ago by Tom.
April 20, 2020 at 2:07 am #1246248Samuel
Generatepress’s menu is provoking IDs duplicated and JS issues.
I turned off the sticky menu and I still have warnings about IDs duplicated : https://yellowlab.tools/result/fmnko7idny/rule/DOMidDuplicated
An lot’s of JS issues : https://yellowlab.tools/result/fmnko7idny/timeline#filter=eventNotDelegated
SamApril 20, 2020 at 9:39 am #1246921TomLead DeveloperLead Developer
The duplicate ID issue is a known issue with our sticky navigation when set to fade/slide.
If it’s a big issue, you can set the transition to “None” for now until we fix it. The issue comes from the navigation having to copy itself when set to “fade/slide”. We haven’t fixed it yet as we’re trying to rebuild the entire thing in vanilla JS.
As for event delegation, I don’t think it actually applies to the menu items as it’s highlighting there. Those events shouldn’t have to be delegated, as the links exist on the page when it loads. I’ll do some more research on this.
Thanks! 🙂April 22, 2020 at 10:47 am #1249620Samuel
Hi, thanks for your reply, it appears that I have this duplicate ID warning even with the sticky menu set as Off. And by the way when it’s On I never use the transition effect.April 22, 2020 at 4:01 pm #1250048TomLead DeveloperLead DeveloperApril 23, 2020 at 12:34 am #1250561Samuel
Here you go, it’s off nowApril 23, 2020 at 9:10 am #1251667TomLead DeveloperLead DeveloperApril 23, 2020 at 10:25 am #1251809Samuel
Here you go, I didn’t remember the other sticky part. Now it’s off, and I can see the the new report that Ids are not duplicate anymore. But there is still the event delegation warning : https://yellowlab.tools/result/fms23q96s4/rule/jQueryNotDelegatedEvents
ThanksApril 23, 2020 at 4:40 pm #1252346TomLead DeveloperLead Developer
- You must be logged in to reply to this topic.