[Resolved] Menu provokes Ids Duplicated and JS issues

Home Forums Support [Resolved] Menu provokes Ids Duplicated and JS issues

Home Forums Support Menu provokes Ids Duplicated and JS issues

Viewing 8 posts - 1 through 8 (of 8 total)
  • Author
    Posts
  • #1246248
    Samuel

    Hello,

    Generatepress’s menu is provoking IDs duplicated and JS issues.

    I turned off the sticky menu and I still have warnings about IDs duplicated : https://yellowlab.tools/result/fmnko7idny/rule/DOMidDuplicated

    An lot’s of JS issues : https://yellowlab.tools/result/fmnko7idny/timeline#filter=eventNotDelegated

    Thanks,
    Sam

    #1246921
    Tom
    Lead Developer
    Lead Developer

    Hi there,

    The duplicate ID issue is a known issue with our sticky navigation when set to fade/slide.

    If it’s a big issue, you can set the transition to “None” for now until we fix it. The issue comes from the navigation having to copy itself when set to “fade/slide”. We haven’t fixed it yet as we’re trying to rebuild the entire thing in vanilla JS.

    As for event delegation, I don’t think it actually applies to the menu items as it’s highlighting there. Those events shouldn’t have to be delegated, as the links exist on the page when it loads. I’ll do some more research on this.

    Thanks! 🙂

    #1249620
    Samuel

    Hi, thanks for your reply, it appears that I have this duplicate ID warning even with the sticky menu set as Off. And by the way when it’s On I never use the transition effect.

    #1250048
    Tom
    Lead Developer
    Lead Developer

    The sticky menu is on right now. Can you turn it off so I can take a look?

    #1250561
    Samuel

    Here you go, it’s off now

    #1251667
    Tom
    Lead Developer
    Lead Developer

    Looks like the mobile header feature still has sticky enabled.

    #1251809
    Samuel

    Here you go, I didn’t remember the other sticky part. Now it’s off, and I can see the the new report that Ids are not duplicate anymore. But there is still the event delegation warning : https://yellowlab.tools/result/fms23q96s4/rule/jQueryNotDelegatedEvents
    Thanks

    #1252346
    Tom
    Lead Developer
    Lead Developer

    Yea, I’ll do some research on that. I don’t think it applies in this instance, but I’ll check 🙂

Viewing 8 posts - 1 through 8 (of 8 total)
  • You must be logged in to reply to this topic.