- This topic has 6 replies, 3 voices, and was last updated 1 year, 2 months ago by roadlink.
January 5, 2021 at 4:30 am #1606268Adrien
Dear GP Team,
Im working on google lighthouse >> Accessibility right now.
I’m only left with one notice which is that the Link
<a href="#">does not have a discernible name. It is the add to cart panel of the site template called “Niche”.
To solve this I would need to insert an arial-label.
However, I am stuck here and I can’t figure out how to add it into the add to cart panel link.
Sorry to bother about that really. I know you’re super busy with GPblocks pro. So excited to get it 😉
Best, AdrienJanuary 5, 2021 at 1:46 pm #1607149TomLead DeveloperLead DeveloperJanuary 6, 2021 at 6:02 am #1607863Adrien
I made a quick video for you: https://www.awesomescreenshot.com/video/2279091?key=6a22ae4f9068708a6f0f08df3a51f1f4
Appreciate your help. Best, Adrien.January 7, 2021 at 11:27 am #1609976TomLead DeveloperLead Developer
That’s strange, as the link itself has text (Continue Shopping). I wouldn’t have thought that a link that contains static text would also need an aria-label, as the text itself is the label for the link.
As of right now that Continue Reading div isn’t filterable, so there’s no way to alter the HTML (add an
aria-label) without editing the plugin itself.
I can add a filter to that area in 1.13.0. I could also add an
aria-labelto it by default, but I’ll need to research that a bit as I’m not 100% sure it’s necessary.January 7, 2021 at 12:41 pm #1610043Adrien
Appreciate your reply Tom and your taking the time.
I was working on this by pure vanity 😉 Hence, please do not worry at all. I’ll just skip this and see if one day you come up with something or if this is in fact a false error from the lighthouse.January 8, 2021 at 9:39 am #1611255TomLead DeveloperLead DeveloperApril 5, 2021 at 12:49 pm #1722495roadlink
This issue is still exist.
- You must be logged in to reply to this topic.