- This topic has 7 replies, 3 voices, and was last updated 4 years, 1 month ago by Grant.
-
AuthorPosts
-
March 22, 2020 at 2:24 pm #1206565Grant
Just noticed that the css in all.min.css has a possible incorect value:
.generate-back-to-top:before{-moz-osx-font-smoothing:grayscale;-webkit-font-smoothing:antialiased;font-style:normal;font-variant:normal;text-rendering:auto;line-height:1;speak:none}
Should be either auto, never, always CSS Speech Module
I changed to:
generate-back-to-top:before{-moz-osx-font-smoothing:grayscale;-webkit-font-smoothing:antialiased;font-style:normal;font-variant:normal;text-rendering:auto;line-height:1;speak:auto}
Let me know what you think!
Edit: I had to change the syle.min.css style.css as well. I am probably missing one…
Edit2: Also found:.button.loading:before{content:"\e900";display:inline-block;font-family:"GP Premium";speak:none;font-style:normal;font-weight:400;font-variant:normal;text-transform:none;line-height:1;-webkit-font-smoothing:antialiased;-moz-osx-font-smoothing:grayscale;-webkit-animation:spin 2s infinite linear;animation:spin 2s infinite linear;margin-right:7px}.load-more .button:not(.loading)
I am giving up for now trying to find all the changes…March 22, 2020 at 4:19 pm #1206627TomLead DeveloperLead DeveloperHi there,
In this case, we can use
speak: none
, as we don’t want screen readers to try and say the icon (which won’t make sense): https://css-tricks.com/almanac/properties/s/speak/March 22, 2020 at 5:00 pm #1206644GrantRight I just can’t find the value of none in any official docs?
That page you linked to shows none however when you click the link on that page to the w3 specs (https://www.w3.org/TR/css3-speech/) it doesn’t show “none” as an option.
I haven’t been able to validate my site since this, what am I missing?
March 23, 2020 at 3:41 am #1207143DavidStaffCustomer SupportHi there,
none
is a legacy value, it was replaced in a later CSS spec withnever
.
So tryspeak: never;
March 23, 2020 at 7:13 am #1207510GrantOkay thanks, I was trying to be safer with auto. I replaced all except for one that I can’t find.
.button.loading:before{content:"\e900";display:inline-block;font-family:"GP Premium";speak:none;font-style:normal;font-weight:400;font-variant:normal;text-transform:none;line-height:1;-webkit-font-smoothing:antialiased;-moz-osx-font-smoothing:grayscale;-webkit-animation:spin 2s infinite linear;animation:spin 2s infinite linear;margin-right:7px}
Thanks again,
GrantMarch 24, 2020 at 11:51 am #1208843GrantGot them all and the site now validates!
Thanks!
March 24, 2020 at 6:22 pm #1209066TomLead DeveloperLead DeveloperThanks for the heads up! We’ve fixed this in GP 2.5.0 🙂
March 24, 2020 at 6:51 pm #1209072GrantThanks Tom I appreciate you and your team.
Cheers!
-
AuthorPosts
- You must be logged in to reply to this topic.