[Support request] Images in edit mode align right. But display left (RTL Problem?)

Home Forums Support [Support request] Images in edit mode align right. But display left (RTL Problem?)

Home Forums Support Images in edit mode align right. But display left (RTL Problem?)

Viewing 7 posts - 1 through 7 (of 7 total)
  • Author
    Posts
  • #611268
    Nir

    I align an image to right in edit mode.
    I see it on the right side (In edit mode).
    When I exit edit mode, I display the page, I see the image on the left page side.

    I am working with a Right to Left (RTL) WordPress version (Hebrew).

    What is the problem?
    Can you help?

    Nir Petrank

    To see the new website with the problem you have to add a line to Hosts file –
    198.20.116.197 ecocheck.co.il http://www.ecocheck.co.il
    The running website is old and I am making a new one with Generatepress

    GeneratePress 2.1.2
    GP Premium 1.6.2
    #611618
    Leo
    Staff
    Customer Support

    Hi there,

    When something works in customizer preview but not on live site, it’s generally a caching issue.

    Can you try clearing all plugin cache and server cache you might have?

    #611953
    Nir

    Hello Leo,

    I don’t have a cache like LiteSpeed Cache, W3 Total Cache and so on.
    The website is new and I didn’t put any cache on it.

    I have this problem with all the websites I use Generatepress – 5 websites.
    I have about – 30 websites with Pojo themes (Pojo.me) – and I don’t have this problem with their theme.

    Please ask Tom to think about it.

    It is something with RTL.
    It is not a usual problem.
    I think it is in the theme code.

    I also disabled all the plugins in 1 Generatepress website.
    This website has only one page – home page without nothing in it.
    It is a new website I started this week.
    So I tried to set an image to left in edit mode.
    The website displays it on the right side.

    Nir Petrank

    #612243
    Tom
    Lead Developer
    Lead Developer

    Sounds like it’s being caused by this CSS: https://github.com/tomusborne/generatepress/blob/2.1.2/rtl.css#L39-L46

    It was likely a mistake adding that in the first place. Aligning left and right should be up to user (regardless of using RTL or not).

    I worry about removing it now, as it will cause some images to switch sides on some RTL installations. However, I think in the long run it’s the right call.

    #612343
    Nir

    OK. So did you change the CSS?
    Is there a new version?
    What do I need to do?

    I have websites that this change will affect them.
    But I don’t care.
    I will change them.

    Nir Petrank

    #612359
    Nir

    I copied the code with the needed change to my website Custom CSS.
    And yes, it works well now.

    Will you change it in the theme itself?

    Nir Petrank

    #612493
    Tom
    Lead Developer
    Lead Developer

    Yes, I’ll likely get this change added in GP 2.2.

    Thanks!

Viewing 7 posts - 1 through 7 (of 7 total)
  • You must be logged in to reply to this topic.