[Resolved] hr tag prob in Version: 1.3.46

Home Forums Support [Resolved] hr tag prob in Version: 1.3.46

Home Forums Support hr tag prob in Version: 1.3.46

  • This topic has 4 replies, 2 voices, and was last updated 7 years ago by Tom.
Viewing 5 posts - 1 through 5 (of 5 total)
  • Author
    Posts
  • #295446
    albabes

    Hi Tom
    Heads up in GP v1.3.46

    You have this hr tag
    hr{background-color:rgba(0,0,0,.1);
    with no closing bracket

    Thanks for my 1st afil pymt recently. Proud to sell you products.
    PS. Why not do afil on you mega menu also?
    PS2. Why no advertise that on GP site?

    #295447
    albabes

    Oh yeah, why Rbga on the hr tag?
    hr{background-color:rgba(0,0,0,.1);
    Why not html color?

    #295450
    Tom
    Lead Developer
    Lead Developer

    There’s a closing bracket: https://github.com/tomusborne/generatepress/blob/1.3.46/style.unmin.css#L1132-L1138

    Mega menus aren’t used by all users, so I prefer to keep it as a separate thing that you can add if you want to or not.

    I use RGBA as it will work even if you make your background color dark – if I used a light color, it would look terrible on dark backgrounds.

    Let me know if you need more info ๐Ÿ™‚

    #295454
    albabes

    Excuse my css ignorance.
    Please delete post

    #295455
    Tom
    Lead Developer
    Lead Developer

    No problem at all! Always feel free to point something out if you think it isn’t right ๐Ÿ™‚

Viewing 5 posts - 1 through 5 (of 5 total)
  • You must be logged in to reply to this topic.