Site logo

Archived topic

header.php suggestion

2 replies · Started by Darryl on January 15, 2015

Viewing posts 1–3 of 3

Tom,

Great theme. I do have one suggestion though. It's not a big deal to me, but it's a change I make in every site I build using your theme.

In header.php, I move:

<?php if ( is_active_sidebar('header') ) : ?>
<div class="header-widget">
<?php dynamic_sidebar( 'header' ); ?>
</div>
<?php endif; // end sidebar widget area ?>

to directly above:

<?php do_action( 'generate_after_header_content'); ?>

This makes more sense when you're using the theme to build business sites. Without the above change, when viewing on a tablet or phone, it places the dynamic_sidebar above the logo. If you use the dynamic_sidebar like I do to hold the company slogan and phone number, it looks rather strange seeing the slogan and phone number above the logo.

Thanks for the suggestion!

Do you ever run into any issues with the header widget floating right? Usually elements need to be on top of the other elements to float to the right of them.

I'll do some playing around :)

I haven't run into any float issues yet with your theme but I'll keep an eye on it.

This archived topic is closed to new replies.