- This topic has 5 replies, 2 voices, and was last updated 3 years, 6 months ago by Tom.
November 1, 2018 at 9:41 am #716581wekhter
I tested the GP 2.2 pre-release + Gutenberg compatability, and here are some things I noticed:
1) Although the editor adapts itself to the content width, it doesn’t take into account any spacing options. So for instance if you set left & right spacing to something large (like 100px instead of the default 40px) it isn’t reflected in the backend. This means the line length isn’t the same as the frontend, or the relative width of regular content vs wide content.
2) The button element in the editor takes on the colors set in the customizer, but not any typography options (ex. font weight, text transform)
3) You’re allowing people to choose full-width settings for blocks (ex images) but since they still have to obey the content width, on the frontend they display the same way as extra-wide blocks. Should they look the same in the backend as well? Or I wonder if it would make more sense to not declare support for fullwidth?
4) In GP buttons by default have no border-radius, but the default border style in Gutenberg is called rounded. There is no difference between changing from the default rounded to square. Would it make sense to create a rounded style so that people can actually switch the two in the editor? Is it possible to change the default option in Gutenberg to square instead of rounded?GP Premium 1.7.3November 1, 2018 at 2:36 pm #716780TomLead DeveloperLead Developer
Thanks so much for this! Truly awesome.
1. Content width is a tough one. There are tons of variables and the backend logic gets really complicated, really fast. We’ll try to improve it a bit, but I don’t think it will ever be 100% accurate.
2. Fixed in alpha.3
3. I wish we could declare wide support and not full width support. The way WP suggests full width support is very hack-y. If a sidebar is present, the full width option will take on the same width as the wide width option. You can imagine how terrible a full width section would look when sidebars are there as well.
4. Good point, we’ve made it so GP respects the round button by default. It doesn’t look like there’s a way to change the default. I’m not sure why they’ve chosen a rounded button as default.
Thanks again for your feedback! I really appreciate it 🙂November 1, 2018 at 4:14 pm #716836TomLead DeveloperLead DeveloperNovember 2, 2018 at 3:12 pm #717635TomLead DeveloperLead DeveloperNovember 19, 2018 at 2:36 pm #731425wekhter
Hi again @Tom,
Just updated to 2.2 and things are looking great, just one thing: looks like like
.wp-block-button__link:not(.has-background)color (color of text on gutenberg button block) is being overridden by
.inside-article a(color of links within post content) since it has higher specificity.November 19, 2018 at 2:38 pm #731428
- You must be logged in to reply to this topic.