- This topic has 14 replies, 3 voices, and was last updated 6 years, 2 months ago by
Tom.
-
AuthorPosts
-
January 13, 2020 at 10:18 am #1130865
Eric
Hi,
I am working with MediaVine for advertisements and I just switched to your theme (live today after a month of testing).
Currently, it appears to go full width at 768px and MediaVine is requesting a change to make it happen at 999px. Is that customizable? I am trying to avoid changing the parent theme or to copy everything into the child theme.
I am willing to wait for an update to the theme if that could be an option.
Thanks,
Eric.January 13, 2020 at 10:53 am #1130885Leo
StaffCustomer SupportHi there,
I believe this is what you are looking for:
https://generatepress.com/forums/topic/gpp-1-9-1-woo-columns/#post-1101238Let me know 🙂
January 13, 2020 at 12:37 pm #1130977Eric
Yes, it looks like that can work. I assume I can use an element? I have the premium plugin. Can you point me to another article on doing the setup?
Thanks
January 13, 2020 at 12:40 pm #1130979Leo
StaffCustomer SupportThe filter will need to be added with one of these options:
https://docs.generatepress.com/article/adding-php/January 13, 2020 at 12:44 pm #1130983Eric
Got it. I am already using a child theme for a few shortcode functions so I will do that.
Eric.
January 13, 2020 at 12:45 pm #1130985Leo
StaffCustomer SupportSounds good 🙂
January 13, 2020 at 1:00 pm #1131007Eric
I tried this in my functions.php and it doesn’t work.
/**
* Snippet from Generate Press to adjust the media content size
*/
add_filter( ‘generate_media_queries’, function( $queries ) {
$queries[‘tablet’] = ‘(min-width: 1000px) and (max-width: 1010px)’;
$queries[‘mobile’] = ‘(max-width: 999px)’;return $queries;
} );January 13, 2020 at 1:09 pm #1131014Eric
I am basically trying to go with the full content spacing as with mobile once it reaches 999px. Tablet and Mobile to have full content view and and drop the columns.
January 13, 2020 at 5:04 pm #1131135Eric
How do you validate if the function is getting called and doing what it is supposed to do?
Thanks
January 13, 2020 at 7:06 pm #1131183Tom
Lead DeveloperLead DeveloperHi Eric,
So you want the content area to go full width at 1000px, pushing the sidebar down below the content?
If so, try this CSS only:
@media (max-width: 1000px) { .sidebar, .content-area { float: none; width: 100%; left: 0; right: 0; } .generate-columns { width: 100%; } }Let me know 🙂
January 13, 2020 at 9:27 pm #1131255Eric
I will give it a try but it’s more that the advertisers do not want the sidebar to move down. It can simply go away.
January 13, 2020 at 9:35 pm #1131256Eric
Definitely better. It think it might just work. I will have the advertiser review.
January 14, 2020 at 7:50 am #1131878Tom
Lead DeveloperLead DeveloperAwesome, let me know! 🙂
January 14, 2020 at 10:28 am #1132115Eric
All set. Thanks for the support.
January 14, 2020 at 4:06 pm #1132330Tom
Lead DeveloperLead DeveloperNo problem 🙂
-
AuthorPosts
- You must be logged in to reply to this topic.