- This topic has 25 replies, 5 voices, and was last updated 4 years, 11 months ago by
Elvin.
-
AuthorPosts
-
February 22, 2021 at 2:54 am #1667415
David
StaffCustomer SupportAwesome – glad to hear that!
You can try the snippet provided here and specifying an exact width and height attribute for your mobile logo:https://generatepress.com/forums/topic/how-to-set-height-and-width-for-the-logo-image/#post-1563234
February 28, 2021 at 1:56 pm #1676530Jarryd Salem
Hi David,
That didn’t solve the issue either unfortunately. Still getting a mix of the below issues for LCP:
< div class=”page-hero” >
< h1 >
< p >And this for CLS:
< button class=”menu-toggle” aria-controls=”mobile-menu” aria-expanded=”false” >
< h1 >March 1, 2021 at 9:47 am #1677668Tom
Lead DeveloperLead DeveloperHave you tried using a mobile header logo that isn’t as wide? The main issue I’m seeing right now is that the logo is too wide and is then pushing the mobile menu toggle down.
If that mobile header logo isn’t so wide, it should prevent that jump.
March 1, 2021 at 12:50 pm #1677918Jarryd Salem
Hey Tom,
That solved the CLS issue! Changed to a different logo in mobile header. Thanks so much.
Now just working on the last pieces of the puzzle – FCP and LCP for mobile. On Desktop all CWVs pass with flying colours.
March 2, 2021 at 8:51 am #1679076David
StaffCustomer SupportDid this:
https://generatepress.com/forums/topic/cls-and-lcp-issues/#post-1664175
not resolve the LCP issue ?
March 2, 2021 at 12:56 pm #1679391Jarryd Salem
Hey David,
That fixed the < div class=”page-hero” > issue, but LCP is still red flagged, and PSI is showing either < h1 > as the culprit on most posts, or < p > on some posts.
March 3, 2021 at 12:55 am #1679836David
StaffCustomer SupportDo you still have the preload image functions in place ? If so can you temporarily remove them
April 21, 2021 at 2:54 pm #1743778Andrew
Hey David
I think that last snippet you gave out may fix my issue also with LCP
apologies for my ignorance, what type of snippet should I configure (Java/CSS/HTML) and are there any special settings (such as ‘Only run on-site front-end’)?
Cheers
Andrew
April 21, 2021 at 5:34 pm #1743871Elvin
StaffCustomer SupportHi Andrew,
apologies for my ignorance, what type of snippet should I configure (Java/CSS/HTML) and are there any special settings (such as ‘Only run on-site front-end’)?
The code David provided is a PHP snippet.
You can set the code snippets entry to “Run snippet everywhere”. You can leave priority blank/default.
April 22, 2021 at 1:04 am #1744198Andrew
Thanks Elvin
Alas, that did not fix my LCP issue with the hero image.
I will open a fresh support ticket (hope that’s OK) as my issue may be a bit different, plus I have some hero image padding questions too.
April 22, 2021 at 6:32 pm #1745362Elvin
StaffCustomer SupportThat’s quite tricky to deal with. No problem.
-
AuthorPosts
- You must be logged in to reply to this topic.