- This topic has 7 replies, 2 voices, and was last updated 1 year, 7 months ago by
Leo.
-
AuthorPosts
-
January 14, 2021 at 4:38 pm #1619224
maxms
I am using an element to generate headers on some of my pages. At some point after creating the initial Hook Element I changed a page from a parent to a child page. This particular page had been identified as one to Exclude from the hook. Everything was fine for a few weeks until I went in to make a slight edit to the hook code. After I saved it, several of my pages broke. I went back in to see that the Exclude rule for the page that was moved was still there and set to “Page” in the first dropdown with the second dropdown blank. This apparently equated to excluding from all pages.
I caught it and fixed it but it seems like a potential issue for some in the future and just wanted to point it out. At the very least, if that second dropdown is blank, the rule should be ignored.
Please let me know if you have any questions. Thank you!
January 14, 2021 at 5:01 pm #1619239Leo
StaffCustomer SupportHi there,
That sounds strange for sure. I cannot recall any other mentions on this though so it’s a bit difficult for us to debug.
Any chance you can replicate the issue somehow and let us know the steps to do so?
Thanks ๐
Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/January 15, 2021 at 8:22 am #1620234maxms
The steps would be:
- Create hook element with ‘generate_after_header’
- Set location to all pages
- Create rule to exclude a particular page, then save the hook element
- Go to the excluded page and move it from a parent page to a child
- Test to see whether the hook has been removed from all pages
- View the exclusion in the hook to see that the page specific dropdown is empty
Let me know if this is clear enough. Have a great day.
January 15, 2021 at 11:47 am #1620505Leo
StaffCustomer SupportJust tried the steps but couldn’t replicate the issue:
https://www.screencast.com/t/o5MEpAht1cT7Can you check if I’m the steps correctly?
Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/January 15, 2021 at 12:05 pm #1620520maxms
You’re just changing the level in the menu. I went into the actual page and changed the ‘Parent’ field in the ‘Page Attributes’ meta box:
https://tinyurl.com/y5utgbhoJanuary 15, 2021 at 5:50 pm #1620722Leo
StaffCustomer SupportTried that and still can’t replicate the issue:
https://www.screencast.com/t/JbSF7zMP2Let me know if I’m still missing something here.
Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/January 16, 2021 at 8:48 am #1621472maxms
That was exactly what I did but the 2nd dropdown in the exclude rule went blank.
Good to know it’s not prevalent. I will keep an eye on it with this and other projects and let you know if I see it again.
Thanks so much. Have a great weekend!
January 16, 2021 at 11:35 am #1621628Leo
StaffCustomer SupportNo problem ๐
You as well!
Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/ -
AuthorPosts
- You must be logged in to reply to this topic.