Archived topic
4.9 - Revisions rollback not working when using Sections?
11 replies · Started by Jim on November 17, 2017
Thought it best to start a new ticket for this one...
Unable to rollback Revisions when using Sections. I can select them but after hitting Restore the content remains the same, although checking back in Revisions says it has changed?
Tested on: IE, Safari & (new) Firefox.
(am using Tom's tinyMCEPreInit fix from last night)
Also, seeing lots of gateway timeout errors when saving. May be a red herring though?
Jim
Seeing another 'Sections' issue...
Cannot toggle between 'Content' and 'Settings [top-left links] when inside a 'Section'?
Jim
Hi Jim,
Revisions have never worked within Sections - they're specific to the WP content editor, which Sections doesn't use.
Are the Content/Settings tabs not working even with the fix from the other topic?
OK, I didn't realise there was no 'Revert' on on a page using Sections?
No, If I open a Section (in Content) and the 'View' tab is live then I can then select the 'Settings' hyperlink. However, I can't then get back to Content again by the other link?
If I have the 'Text' tab selected when in 'Content' then I the 'Settings' hyperlink doesn't work?
The content from your Sections is saved into the content editor when you save the post, so there is a history of the content in the regular editor. However, they can't be reverted into each separate section.
I'll take a look at this issue this morning - thanks!
OK, thanks Tom.
Think I found the issue - thanks for reporting it.
If you'd like to test, find this file:
wp-content/plugins/gp-premium/sections/functions/metaboxes/js/generate-sections-metabox.js
Search for:
switchTab: function(e) {
In this function, find this line:
// close lingering wp link windows
if (typeof tinyMCE != "undefined") {And replace it with:
// close lingering wp link windows
if (typeof tinyMCE != "undefined" && 'style' == jQuery( e.currentTarget ).data( 'target' ) && this.ui.panels.find( '#wp-generate-sections-editor-wrap' ).hasClass( 'tmce-active' )) {I'll be release 1.5.4 with the fix either later today or tomorrow morning.
Hi Tom,
It works if you have the 'Visual' tab selected. However, if you have 'Text' selected then you have the same problem. Just tested on a site where GP plugin and WP are running the previous versions and it works fine when 'Text' is selected?
Jim
Nice catch - just adjusted the code to replace up above.
Really appreciate your help with this! :)
Well done Tome - you've cracked!
Thanks for all of your help.
Jim
Great - really appreciate your help testing! :)
I just released GPP 1.5.4.
Thanks again for the help!
