- This topic has 20 replies, 6 voices, and was last updated 2 years, 6 months ago by Ogi22.
November 16, 2017 at 2:38 am #425739Andy
Hi Tom (and all)…
Just upgraded one of my testing build sites with WP 4.9 and I’m finding when I toggle back from TEXT view to VISUAL view in the SECTION editor that it won’t switch tabs, and it generates the following line of code in TEXT view:
<span style="display: inline-block; width: 0px; overflow: hidden; line-height: 0;" data-mce-type="bookmark" class="mce_SELRES_start"></span>
I’ve disabled my own child theme and all other plugins, so I’m only running GP Premium plugin and GP theme. Getting the same issue on another demo site too.
I spotted this thread: https://generatepress.com/forums/topic/problems-editing-headers-in-wordpress-4-9-beta/ where the color pickers were not behaving, and it looks like when I view the SETTINGS view of the SECTION that none of the color pickers are showing (just the field labels).
Anyone else seeing this? For now, I’m leaving all other sites on 4.8…
AndyGeneratePress 1.4GP Premium 1.5.3November 16, 2017 at 3:22 am #425762André
Was about to ask if it’s safe to upgrade to WordPress 4.9. I’ll wait for now.November 16, 2017 at 5:23 am #425852johnzoro
Me tooNovember 16, 2017 at 8:07 am #426032Jim
Yes, I’m seeing this too. Revisions are not working for me since upgrade either?November 16, 2017 at 8:27 am #426045TomLead DeveloperLead Developer
Here’s our demo site using WP 4.9 and GPP 1.5.3: https://www.screencast.com/t/KYCnHqXwC
Am I doing the right things to see this bug?November 16, 2017 at 8:30 am #426049Jim
Hi Tom, can I ping you a login so you can see what’s happening for me please?November 16, 2017 at 8:32 am #426051TomLead DeveloperLead DeveloperNovember 16, 2017 at 8:40 am #426061Jim
ok done via ‘account issue’ form.November 16, 2017 at 8:56 am #426079TomLead DeveloperLead DeveloperNovember 16, 2017 at 9:10 am #426093Jim
Just so you’re aware. Safari is seeing the same issue as Firefox and Although Internet Explorer looks OK, the Revisions don’t role back?November 16, 2017 at 10:01 am #426146Andy
Thanks for taking a look, Tom – I didn’t think to test on Chrome too… that works fine for me on there.November 16, 2017 at 1:30 pm #426286TomLead DeveloperLead Developer
Found the issue. Going to wait a day before releasing 1.5.4 in case any other 4.9 related bugs pop up.
For now, open this file:
tinyMCEPreInit.qtInit["generate-sections-editor"] = this.qt_settings;
And replace it with:
tinyMCEPreInit.qtInit["generate-sections-editor"] = this.qt_settings; tinyMCEPreInit.mceInit["generate-sections-editor"].wp_keep_scroll_position = false;
Would really appreciate it if any of you can do the above just to confirm the fix.
Thanks!November 16, 2017 at 1:56 pm #426299Andy
Fix works on Firefox and Safari here. Awesome.November 16, 2017 at 2:59 pm #426341TomLead DeveloperLead DeveloperNovember 17, 2017 at 12:07 am #426513Jim
I can confirm the Visual & Text tabs now work. However, Revisions rollback don’t work when using Sections? Works OK if you’re not using Sections – Tested on today’s new Firefox.
I’ll open a new ticket.
- You must be logged in to reply to this topic.