- This topic has 12 replies, 4 voices, and was last updated 2 years, 11 months ago by
.
-
Posts
-
Hello.
After the recent update, I first disabled the “navigation search” at a site and then checked the new option for the search modal but the search icon was then lost at the menu. The same happened at another site that didn’t previously have the navigation search enabled.
Didn’t check further with other sites as I first prefer to report this here.
Thanks.
Customer Support
Hello there,
So we can take a closer look at the issue, can you provide admin login credentials?
Please use the Private Information field for this: https://docs.generatepress.com/article/using-the-premium-support-forum/#private-information
Sure. In the meanwhile I also tested other sites and the same happens elsewhere. So, not really specific to this site.
I’m also adding another site here, where the nav search was not previously enabled.You’re still using the old Float system. In Appearance > Customize > General, can you try switching to the current Flexbox system?
Reference: https://docs.generatepress.com/article/switching-from-floats-to-flexbox/
It would be best to backup your site before doing this.
I’m not sure of doing this as all those sites are built with Classic Editor, they don’t use blocks and all of them are still running the Lightweight Grid Columns plugin which is using UNsemantic.
I would much prefer being able to switch to the previous navigation search but I see there is no option for reverting this setting back once you enabled the new search modal and this is really a pity.
I see. I don’t think switching to the Flexbox system would affect those, but if it does and you have a backup, you can safely revert the change made.
What’s important in this is switching to Flexbox allows you to have a
menu_bar_itemssection in your Header where the Search icon is placed by default.If you can create a Staging/test site, you can try it out there first to be sure.
Alternatively, you can try adding this snippet:
add_action( 'generate_after_primary_menu', 'generate_do_search_modal_trigger' );Adding PHP: https://docs.generatepress.com/article/adding-php/#code-snippets
Thanks but I have about 30 sites designed that way and I really don’t feel worth testing all of them…
I just tried the snippet you provided at the first site I previously mentioned but doesn’t seem to have any effect.
As I’m not really interested in the modal, isn’t really a way for using the old nav search with the new version?
Customer Support
Hi there,
i think we can confirm there is a bug.
Quick question – your existing sites where the Primary Nav was activated. Those that you have not changed are they still displaying the old Navigation search ? And are they working correctly ?
Hi David,
Sorry but I’m on holiday right now and have some difficulties to concentrate…
Would you mind rephrasing your question? Not sure I fully understand.Just to clarify though: I didn’t yet update all sites. Only the 2 I mentioned here above (one had the nav search enabled and the second one didn’t have it) plus a 3rd one that had the same config as the first one.
Now, if you want me to test some others I can go on without a problem.
But I *think* I can confirm that the old nav search was still working after the update – if this is what you asked – but not sure 100%. So happy to test a couple of others. Just let me know if I understand this correctly.Lead Developer
Hi there,
Can you check if you have your “Icon Type” set to “SVG” vs “Font” in “Customize > General”. Looks like this may be a bug with the “Font” feature.
If not, are you using the “Floats” value for the “Structure” option in the same section?
Looks like the bug is can happen if either of those options are selected.
If you can’t change either of those options (to “SVG” and “Flexbox”), you can use the following filter to turn the old navigation search back on:
add_filter( 'option_generate_settings', function( $settings ) { $settings['nav_search'] = 'enable'; return $settings; } );Hi Tom,
Site 1 is set with Floats and SVG, site 2 with Floats and Font, and site 3 the same as site 1.
Now, I just tested at another 2 sites that I keep as templates and I can confirm the following:
– one had only the option for the Icon Type and that was set to SVG and no option for the Structure (probably meaning that this was previously set to Flexbox if I’m not wrong): the search modal works fine.
– the second one had also the option for SVG but the structure was on Floats and the modal didn’t work. I then switched to Flexbox (and there was no more option to switch back to Floats) and the modal works after that.This seems to confirm what you suggested above.
As I’m not planning to switch t Flexbox for the existing sites, please let me know whether I can go on and use your snippet or whether you are planning to update anything related to this. Thanks.Hi there,
You can use the snippet to bring the old navigation search back on those sites using floats.
In 3.3.1, we will be removing the new search modal option if we detect the usage of font icons or floats, as it’s a feature that requires flexbox and SVG. At that point, you can turn it back on in the Customizer and ditch the filter.
Let me know if you have any other questions 🙂
Sounds good, many thanks!
- You must be logged in to reply to this topic.
