- This topic has 7 replies, 2 voices, and was last updated 4 years, 10 months ago by
David.
-
AuthorPosts
-
May 27, 2021 at 1:59 am #1799893
James
Hi!
I’ve had some oddness with a client using LearnDash…
They’ve had an issue where the ‘Lesson Content/Topic List’ wasn’t being displayed at the bottom of lessons.
They raised a ticket with LD who said it was a conflict with GP Premium. Well, it turns out that it *might be* but it’s also REALLY odd!
What was happening is that display:none; was/is being added inline on the
with the class .ld-lesson-topic-listDoing some digging around, it turns out it’s just the ‘Spacing’ section within GPP that’s doing this – WHY?!!?!?!?!?! That seems to make no sense.
And what makes even less sense is that on some lessons, turning off ‘Spacing’ will stop the display:none being added, but on others it makes no difference and display:none is still there (after clearing caches, etc.)!
So I’m really not convinced that it’s GPP entirely ‘at fault’ here. Why would the ‘spacing’ options be adding an inline display:none on anything?
Anyway, I’ve fixed it by adding
.ld-lesson-topic-list {
display:block!important;
}in the Customizer CSS – but I thought you’d like to know about this, just in case there’s any issue with GPP!
May 27, 2021 at 4:43 am #1800042David
StaffCustomer SupportHi there,
yeah that is odd – but i can’t see it being a GP thing.
For one, GP doesn’t know LearnDash even exists, secondly GP doesn’t add inline styles to any elements, let alone ones it don’t know about, and lastly that kinda thing would require either a PHP filter or Javascript to add an inline style if it wasn’t present in the original HTML.Most likely theres another front end Javascript that is adding the code – buy why disabling a module corrects it – well thats just bizzarre lol
Do you have a link to a page where i can see the issue – might be some telltale signs as to whats going on?
May 27, 2021 at 6:44 am #1800162James
Hi David,
I’m glad it’s not me then!!!
All the effected pages are behind a paywall I’m afraid.
I’ve uploaded a screenshot showing the line in the code and the block it’s trying to hide at: https://ibb.co/vjyGpvk
Thanks for your help.
May 27, 2021 at 7:10 am #1800368David
StaffCustomer SupportYeah that doesn’t really help 🙂 Would need to see the source code… might be worth asking LearnDash why they thought there was a conflict with GP Premium – could give some insight to the issue – but i cannot think of anything that GP/GPP would do to cause that.
May 27, 2021 at 8:34 am #1800489James
Yeah…
From the ticket emails forwarded by my client, it seems that LearnDash turned plugins off & on until it broke/fixed and that was about it.
I’ll pop a demo user login into the ‘secret’ box for you to take a look at. If you view a lesson you’ll be able to see the code.
Thanks.
May 28, 2021 at 3:48 am #1801288David
StaffCustomer SupportWell this was fun.
First i tracked down the LearnDash script to what was adding the display none inline style.$(document).on('learndash_video_disable_assets', function(event, status) { if ('undefined' === typeof learndash_video_data) { return false; } if ('BEFORE' == learndash_video_data.videos_shown) { if (true == status) { $('.ld-lesson-topic-list').hide(); $('.ld-lesson-navigation').find('#ld-nav-content-list-' + ldVars.postID).addClass('user_has_no_access'); $('.ld-quiz-list').hide(); } else { $('.ld-lesson-topic-list').slideDown(); $('.ld-quiz-list').slideDown(); $('.ld-lesson-navigation').find('#ld-nav-content-list-' + ldVars.postID).removeClass('user_has_no_access'); } } });This line here is setting the display none:
$('.ld-lesson-topic-list').hide();
And theres also this script which is adding theuser_has_no_accessclass to the Content List in the sidebar:
$('.ld-lesson-navigation').find('#ld-nav-content-list-' + ldVars.postID).removeClass('user_has_no_access');Which meant this condition is being met:
if ('BEFORE' == learndash_video_data.videos_shown) { if (true == status) {This looked to me like the elements are auto hidden until ‘something’ is triggered by the Video…. So i played the video, skipped to the last 2 seconds and on complete the
elsescript fired and the styles were updated which was to slide open the list…..Which lead me to this:
https://www.learndash.com/support/docs/guides/video-progression/
Simply put, it looks like the page is behaving exactly how its supposed to – which is don’t show this, until the video has been watched…..
May 28, 2021 at 4:23 am #1801336James
Hi David,
AHA! Now, I’d have never thought of that. It’s a shame that the LearnDash support team couldn’t have told my client that about their own product! 😉
Anyway, fixed by a line of CSS, so all good…!
Thanks for your help on this.
James
May 28, 2021 at 5:36 am #1801433David
StaffCustomer SupportI like a good puzzle 🙂 But yeah – might be worth sharing my reply with LearnDash lol
Glad to be of help.
-
AuthorPosts
- You must be logged in to reply to this topic.