- This topic has 26 replies, 3 voices, and was last updated 4 years, 10 months ago by Tom.
-
AuthorPosts
-
May 6, 2019 at 9:33 am #890884DavidStaffCustomer Support
So your only CSS ( the first rule that you shared ) that would effect those images needs to become this:
.woocommerce ul.products li.product a img { max-width:80%; height: auto; }
May 6, 2019 at 10:02 am #890898ArndHi David,
Thank you for looking into it.
I have replaced the CSS but, unfortunately, it still does not show the products like it used to be in GPP 1.7.7.
https://drive.google.com/open?id=1mMSM5s3H-ugcmePskZ5WgYNpuQIy-INh
In portrait view it looks like this and you can move the page from one side to the other
https://drive.google.com/open?id=1ozIbJoHk4kXahHFMj-ZEhPyzdlQ71BDM
https://drive.google.com/open?id=1jxSodF7x5yiU7xBViAKDFTmw-StkeICvWhen removing the CSS that effects the images completely, it looks quite similar:
https://drive.google.com/open?id=1o0Uv8jLVSG-uvRb1WHh3djUmpu_n_ch8
https://drive.google.com/open?id=1FeXIOTcFvXE61SambbFN6zTsNdyWKEWVCheers Andy
May 6, 2019 at 10:23 am #890914DavidStaffCustomer SupportWould you mind removing that CSS and testing this please:
.wc-related-upsell-columns-4 .related ul.products, .wc-related-upsell-columns-4 .up-sells ul.products, .woocommerce .wc-columns-container.wc-columns-4 .products { grid-template-columns: repeat(4 , 25%) !important; grid-gap: 1.5% !important; }
May 6, 2019 at 11:03 am #890959ArndHi David,
You are a star! This works greatly. Thank you very much.
I have only just realised that I have the same issue on the single product page with the upsell products.
https://drive.google.com/open?id=1NfbNgpnXQApXSsE4CZbT493-XNne1yDq
Would there be a similar solution possible?
Cheers Arnd
May 6, 2019 at 11:10 am #890969DavidStaffCustomer SupportMaybe this:
.wc-columns-container.wc-columns-5 .products, .wc-related-upsell-columns-5 .related ul.products, .wc-related-upsell-columns-5 .up-sells ul.products { grid-template-columns: repeat(5 , 20%) !important; grid-gap: 5px !important; }
May 6, 2019 at 11:27 am #890984ArndPerfect!
Just a couple of things:
– the submenus do drop out not naturally on the actual iPad. It is like clicking the top menu (and the site loads) and then click it again and only then the submenu drop down. I could do a workaround by using only ‘#’ instead of a real URL, but would prefer an actual url
– second: can I send you a few bottles of German wine?
Cheers Andy
May 6, 2019 at 4:15 pm #891152TomLead DeveloperLead DeveloperI believe that is a bug in the theme and the latest iOS version. We’re looking into a fix for 2.3.
I’ll ping David about that wine! haha
May 7, 2019 at 1:04 am #891422ArndThat’s great and that’s great!
Thanks a lot to you bothMay 7, 2019 at 5:33 am #891630DavidStaffCustomer SupportReally glad to be of help. And thank you for the kind offer of wine 🙂
If you wish to make a donation then Tom accepts tips for coffee:https://generatepress.com/ongoing-development/
Or you may just want to leave us a nice review on WordPress.org
May 10, 2019 at 12:27 pm #895671TomLead DeveloperLead DeveloperHi there,
Sorry for the delay on the iPad issue! Was a tough one.
I believe I have this fixed in GP 2.3: https://github.com/tomusborne/generatepress/commit/745c311a29570ccbed7dcdb454fabb37b3e72679
It would be awesome if you could give it a test?
If so, replace the contents of the
wp-content/themes/generatepress/js/a11y.min.js
file with this: https://raw.githubusercontent.com/tomusborne/generatepress/release/2.3/js/a11y.min.jsLet me know if you need more info 🙂
May 10, 2019 at 12:49 pm #895679ArndHi Tom,
I do believe this was tough one! It is beyond what I can understand 🙂
I had a quick test on iPad air and iPad Pro, both with the latest iOS. It works like a charm!
You can test yourself on demo.<MyDomain>.eu/shop if you like. (It’s GPP 1.8.2) installed)
Great job! Thank you very much.
Cheers Andy
May 10, 2019 at 1:03 pm #895685TomLead DeveloperLead DeveloperAwesome! Thank you for confirming – I appreciate it 🙂
-
AuthorPosts
- You must be logged in to reply to this topic.