- This topic has 5 replies, 2 voices, and was last updated 3 years, 2 months ago by David.
-
AuthorPosts
-
February 5, 2021 at 1:57 am #1646575Roberto Enrique
Today I realized that in a site I’m building, the blue border when you have some block selected, just disappeared. π
…I mean, this “blue” line:
In the site I’m referring to, it’s like this:
The only thing I remember doing was activating a global style for the buttons, just to test the new feature, but honestly I can’t blame it on that.
Another curious issue, which I honestly don’t know how and when exactly started occurring, is that the borders both around the “Product Sort” drop down on products archives and the border around the “quantity increments” buttons in single product page are missing as well:
This is what I mean:
In order to bring them back I need to add this CSS:
/*Woocommerce bring back borders here and there :-( */ .woocommerce form .quantity.buttons-added .qty, .woocommerce form .quantity.buttons-added .minus, .woocommerce form .quantity.buttons-added .plus, .do-quantity-buttons form .quantity:not(.buttons-added)::before, .do-quantity-buttons form .quantity:not(.buttons-added)::after, .woocommerce-ordering select, .variations .value select{ border-color:#d2d2d2; }
Thanks in advance for your support.
February 5, 2021 at 4:28 am #1646714DavidStaffCustomer SupportHi there,
missing borders in the block editor – see this github:
https://github.com/WordPress/gutenberg/issues/23892
Long read – simply put the borders were removed around most ( not all ) blocks. Its seems gutenberg team saw it as a design improvement, as Block editing is not longer a novel experience they deemed them unnecessary.
The borders missing on the front end – thats a different issue … you provided a log in but no URL to the site, can you provide so i can take a look ?
February 5, 2021 at 5:08 am #1646753Roberto EnriqueHere it is. Thanks π
February 5, 2021 at 6:04 am #1646831DavidStaffCustomer SupportOk so, GP premium has this function:
generate_premium_check_text_color
.
It returns a light or dark value based upon the text color.
This value then determines whether certain elements such as borders are painted light or dark.The logic behind this is based on Contrast Accessibilty. ie. Light Text we would expect to be on a darker background, and therefore borders should be painted in a light color.
Sometimes that logic is wrong, and it does require some CSS to correct it.
February 5, 2021 at 12:48 pm #1647455Roberto Enriquemmmm, I thought about something like that.
Nice to know π
I’ll fiddle around.Thank you very very very much.
February 5, 2021 at 2:06 pm #1647520DavidStaffCustomer SupportYou’re welcome!
-
AuthorPosts
- You must be logged in to reply to this topic.