- This topic has 9 replies, 2 voices, and was last updated 1 month, 1 week ago by David.
March 4, 2020 at 12:08 pm #1185163wekhter
Hi, I was trying to use the built-in unsemantic grid (https://docs.generatepress.com/article/creating-columns/#using-built-in-unsemantic-grid) to set up some elements that that will appear across multiple pages. I’m setting up a simple grid that should show 4 columns on desktop, 3 columns on tablet, and 2 columns on mobile.
When I tested my code, I saw that the 3-column layout on tablet wasn’t working. Looking at the CSS in the theme, it seems like the
tablet-grid-33rule is missing. The
tablet-pull-33styles are there, so I guess this was just an oversight?March 4, 2020 at 5:24 pm #1185337DavidStaffCustomer SupportMarch 5, 2020 at 11:03 am #1186233wekhter
@David That does make it so that the tablet-grid-33 works, but it still feels like an oversight that the lite version includes the other tablet-*-33 rules (pull, push, etc) but not the basic tablet-grid-33 rule.March 5, 2020 at 6:08 pm #1186521TomLead DeveloperLead Developer
The combined CSS version includes a slimmed-down version of Unsemantic Grid. Only classes that are used in the theme are included by default. It’s the beginning of an effort to remove CSS that isn’t 100% necessary for the theme to function.March 6, 2020 at 8:06 am #1187157wekhter
@Tom I can understand that–I’m just saying that all the other rules related to
tablet-*-33are still in the files, as well as all the rules related to
tablet-*-66so it seems like an oversight that either a) just the
gridrule is missing, or b) that the other
-66rules are present at all.
EDIT: Just to be clear, one of the reasons I brought up it not working was because I just plopped the code from the docs page on columns (https://docs.generatepress.com/article/creating-columns/#using-built-in-unsemantic-grid) onto the site and the second example uses
tablet-grid-33.March 6, 2020 at 6:09 pm #1187515TomLead DeveloperLead Developer
I’ll take a closer look. I’m assuming I had a reason for doing so, but I’ll dig deeper to make sure I didn’t overlook something 🙂August 14, 2020 at 4:50 am #1402410Nic
may i ask why you use unsemantic grid? never heard of it and it seems deprecated. github repo is not actively maintained. better use something else than this please. for instance bootstrap4 (grid only).August 14, 2020 at 5:21 am #1402451DavidStaffCustomer Support
GP Theme is over 6 years old, which is way before Flexbox or CSS Grid was well supported, Unsemantic grid fulfilled the needs then and is part of that legacy.
We have been migrating our CSS to Flexbox over the last few theme releases.
In GeneratePress 3.0 we are replacing Unsemantic with Flexbox.
Existing sites will have the choice to continue using Floats (Unnsemantic) or switch to Flexbox. All new sites in that theme will default to Flexbox.August 14, 2020 at 5:54 am #1402487Nic
any vague plans when to release GP 3.0?August 14, 2020 at 7:49 am #1402782DavidStaffCustomer Support
Very soon – we’re working on the public alpha release for end of this month at the latest. We’re just checking to see if WP 5.5 introduced some changes we need to account for which is the main delay.
- You must be logged in to reply to this topic.