- This topic has 10 replies, 2 voices, and was last updated 4 years, 3 months ago by Tom.
July 3, 2017 at 9:46 am #343489Moritz
I have lost sticky menus on the mobile variants of two sites. One the first site (http://www.praxis-steinhilber.de/) I now no longer have a sticky menu at all. Originally a slide-out menu could be triggered by clicking “Menu”. With this button now lost there is no navigation on mobiles.
On the second site the menu isn’t “sticky” anymore (http://www.holm-hadulla.com/) – it just stays at the very top of the page, i.e. invisible when scrolling. Originally the “Menu” button was sticky to the top of the page, upon clicking showing the normal (i.e. non-slide-out) menu.
I haven’t changed these sites in a while and hence am not sure what happened that these functionalities have been lost. For debugging I tried disabling all non-GP plugins but sadly that didn’t help which is why I am looking for help here.
Thank you for your help!
MoritzGeneratePress 1.3.48GP Premium 1.3.1July 3, 2017 at 10:57 am #343532TomLead DeveloperLead Developer
On the first site, your mobile menu is set to 0px height.
This might be custom CSS, or you might have it set in Customize > Layout > Primary Navigation > Menu item height (mobile).
On the second site, both desktop and mobile seem to be sticky for me – the page just needs to be long enough for the sticky menu to initiate.July 4, 2017 at 12:24 am #343815Moritz
Thank you for your quick feedback – much appreciated. On the first site the problem is now fixed, I changed the menu height to a non-zero number in the Customizer. I didn’t notice at first there are now separate settings for desktop and mobile sites!
On the second site I am afraid I still cannot get the menu to work as expected. Some of the sites appear long enough to warrant the sticky menu, i.e. http://www.holm-hadulla.com/lebenslauf/ but still no dice, what’s wrong here?
Thank you for your help
MoritzJuly 4, 2017 at 1:01 am #343837TomLead DeveloperLead Developer
Strange, seems to work sometimes and not others. I’m assuming it has something to do with your navigation being in the sidebar. I’ll look into it 🙂July 10, 2017 at 12:59 am #346824Moritz
I reverted back to the GP child theme “Freelancer” but the problem persists on the second site, i.e. the sticky navigation is not actually sticky on mobile, i.e. the menu does not show up when scrolling down. I also changed the menu location from “Left Sidebar” to “Below Header” and indeed, the sticky menu now works! Any progress on your side?July 11, 2017 at 12:16 am #347441TomLead DeveloperLead Developer
No solid solution yet, but I’m working on it. The way the mobile navigation works with the sidebar navigations isn’t ideal as is, so I might use this as an excuse to re-write it.July 14, 2017 at 11:48 am #349504TomLead DeveloperLead Developer
This has been fixed in the next versions of GP and GP Premium (both will need to be updated).
GPP 1.4 beta will be released today, which has the fix.
Then I can help you get the latest theme version if you’d like to test the two fixes together.
Thanks!July 15, 2017 at 1:11 am #349710Moritz
Great news, thanks for working on this. I am happy to test the revised version now or upon official release.July 17, 2017 at 1:30 pm #350807TomLead DeveloperLead Developer
GPP 1.4 beta.1 was just released – you can get it like this: https://docs.generatepress.com/article/beta-testing/
GP 1.3.49 beta.1 was also released – these two releases together should fix this issue.
You can download it here: https://tomusborne.com/dev/temp/generatepress.zip
This plugin makes it easy to overwrite old theme/plugin versions: https://en-ca.wordpress.org/plugins/easy-theme-and-plugin-upgrades/
Let me know if this fixes it or not 🙂July 18, 2017 at 1:07 am #351031Moritz
Excellent work, sticky menu now works on Internet Explorer, Firefox and Opera. It seems I had to clear the browser cache once following the updates to GeneratePress and GP Premium. Thanks again for your help!July 18, 2017 at 8:50 am #351211
- You must be logged in to reply to this topic.