Archived topic
Sidebar touches main content
8 replies · Started by Amir on July 28, 2019
Hi, please take a look at the link. Main content is too low and sidebar is touching it even though there is spacing.
When I adjust the separating space it seems to be fine, but when I update the problem reoccurs.
Hi there,
That's strange. Does the issue persist if you change the site language to English?
Hi again,
Spacing works correctly when the language is set to English.
Sorry have you fixed this? Everything looks normal to me in the non-English site currently:
https://www.screencast.com/t/qGbTGC5GE
Let me know if I'm missing something :)
Hi there, sorry it wasn't clear. This is isn't fixed because the website needs to be in Hebrew. Right now everything is aligned to the left because I changed the language to English. I assume the problem is related to the RTL language. I changed the language again so you can see the problem.
Ahh ok.
We will take a closer look.
Can you try this CSS for now?
.rtl.separate-containers .inside-right-sidebar, .rtl.separate-containers .inside-left-sidebar {
margin-top: 30px;
margin-bottom: 30px;
}
.rtl.right-sidebar .site-main {
margin: 30px;
}
Adding CSS: https://docs.generatepress.com/article/adding-css/
Let me know :)
Works, thanks.
By the way, the problem only occurs with 1 sidebar.
EDIT: Solution isn't perfect as it causes the main content to have unnecessary 30px left margin.
I changed it this way and now it seems to work:
.rtl.right-sidebar .site-main {
margin-right: 30px;
}
Awesome.
We will take a closer look and fix it in the next version :)
Hi there,
We've updated the rtl.css file, which will be live in GP 2.4.
For now, you can replace the contents of your rtl.css file with this: https://raw.githubusercontent.com/tomusborne/generatepress/release/2.4/rtl.css