- This topic has 23 replies, 4 voices, and was last updated 3 years, 12 months ago by
Tom.
-
AuthorPosts
-
March 23, 2019 at 1:03 pm #847707
epickenyan
Hi. I use separate containers. Below 768px, I see the container leaves space above and on the left side with a grey background (check using mobile not minimizing browser window on pc). How do I remove that white space on the left while retaining the content padding? This does not happen on single posts and pages though (I think it might be the 20px padding for the separate containers).
Second question, would you mind introducing a specific padding feature for the images in the blog section? The padding that is introduced by ticking the box in the customiser leaves a wide white space on the right side of the images which can only be remedied through custom CSS.GeneratePress 2.2.2GP Premium 1.7.8March 23, 2019 at 3:48 pm #847783Leo
StaffCustomer SupportHi there,
Hmm that should be removed by default.
Can you try disabling the caching plugins first so I can tell if it’s a bug or not?
Let me know ๐
Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/March 23, 2019 at 5:41 pm #847857epickenyan
Thanks for the suggestion. I use LiteSpeed Cache plugin (my host is on Litespeed) and the ‘combine CSS” feature is what was causing the issue. I disabled it and now it is working fine. Does combining CSS work well with GP?
March 23, 2019 at 7:26 pm #847904Leo
StaffCustomer SupportI think you have to exclude a few files in order to use the combine CSS option.
Do you see much speed difference with and without that option?
Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/March 24, 2019 at 12:59 am #847988epickenyan
Yes, I am losing some percentage points in Gtmetrix (2% on average) and Yslow (6%). Also in Google Lighthouse (2-3%). The major issue is to “make fewer HTTP requests”. This happens after disabling combine CSS feature.
March 24, 2019 at 5:39 am #848119David
StaffCustomer SupportDoes the cache include aggregate/combine inline CSS? If so try deselecting that option instead. Combining files shouldn’t effect this option.
Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/March 24, 2019 at 10:35 am #848419epickenyan
It does not combine inline CSS. But it does minify inline CSS and JS. Disabling both of them when CSS combine is on did not solve the above issue. So the issue is Combine CSS which is making the container on mobile to have the padding on the left. I am using this code temporarily to solve the problem.
@media (max-width:768px){.generate-columns { padding-left:0px!important; }}
March 24, 2019 at 4:35 pm #848584Tom
Lead DeveloperLead DeveloperNot sure there’s a way around it, as it’s mixing up the order of the CSS.
Maybe try something like Autoptimize for the file combining? It does a great job of this without messing up the order.
Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/
Ongoing Development: https://generatepress.com/ongoing-developmentMarch 24, 2019 at 4:37 pm #848586epickenyan
I will try to do so. Though I was trying to reduce the number of optimization plugins because this plugin specifically targets the server functions directly for optimization.
March 24, 2019 at 4:49 pm #848599Tom
Lead DeveloperLead DeveloperIn that case, you might need to stick with your CSS as a workaround. Unless of course there’s a workaround to maintain the proper order of the CSS in LiteSpeed Cache.
Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/
Ongoing Development: https://generatepress.com/ongoing-developmentMarch 24, 2019 at 4:51 pm #848603epickenyan
Thanks, Tom. I will try to raise the issue with them directly and then get back.
March 24, 2019 at 4:52 pm #848607Tom
Lead DeveloperLead DeveloperSounds good ๐
Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/
Ongoing Development: https://generatepress.com/ongoing-developmentMarch 31, 2019 at 10:50 am #855137epickenyan
Hi Tom, this question was not addressed
Second question, would you mind introducing a specific padding feature for the images in the blog section when separate containers are enabled? The padding that is introduced by ticking the box in the customiser leaves a wide white space on the right side of the images which can only be remedied through custom CSS.
March 31, 2019 at 4:19 pm #855293Tom
Lead DeveloperLead DeveloperI’m not too sure what you mean there? Like separate padding for around the images than everything else?
Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/
Ongoing Development: https://generatepress.com/ongoing-developmentApril 1, 2019 at 3:25 am #855583epickenyan
When the containers are not separated (in the blog section), the padding on the images is even. When you separate them, it leaves a big white space on the right side and top side of each image (see http://prntscr.com/n5ua2c). So, yes, I agree with your suggestion to introduce a feature that separates padding for images with everything else.
-
AuthorPosts
- You must be logged in to reply to this topic.