Archived topic

primary nav is duplicated in code when placed in sidebar

5 replies · Started by morriscountynj on March 26, 2018

Viewing posts 1–6 of 6

March 26, 2018 at 9:23 am #531278

I'm working on a new site - for this one, I decided to place the navigation in the left sidebar.

However, when I go to inspect the code, I notice something strange. The navigation (<nav id="site-navigation">) shows up in TWO places in the code: both after the header, AND within

Screenshot (see the two highlighted areas):
https://drive.google.com/file/d/1gOY7GVaQURVwVz_Jy_6XxWmS09RKPZGl/view?usp=sharing

I tried disabling menu plus, my child theme, and GP premium, but this is still happening.

This is a big issue for accessibility. Screen reader users would be very confused with two identical menus showing up in code, even if you only SEE one visually on the screen.

At minimum, I need to be able to add aria-label="Duplicate Menu" or "Mobile Menu" or the like to the one that appears below <header>.

Can you help me achieve this? I'll edit the javascript or whatever I need to do to make this work.

March 26, 2018 at 9:44 am #531305

Good point! I just added this into the next version of GP: https://github.com/tomusborne/generatepress/commit/fd0775ef28ca5426fc182bd037d859cb980fe9c3

March 26, 2018 at 9:50 am #531313

woo that's awesome! when are you going to push that out? should i just add it myself to the parent theme for the time being?

March 26, 2018 at 9:57 am #531332

First half of April. You can absolutely add it yourself for now :)

March 26, 2018 at 10:39 am #531408

awesome, thank you :)

March 26, 2018 at 10:43 pm #531969

No problem! Thank you!

This archived topic is closed to new replies.

Start building better websites today.