- This topic has 31 replies, 4 voices, and was last updated 3 years, 7 months ago by Tom.
March 4, 2017 at 3:05 am #286886Seppo
It seems when H1 is applied in the post editor, the resulting heading doesn’t respect colors set in the customizer for H1. Instead, it picks up the text color set for body element. This is easy to fix this custom CSS, but I wanted to point out what seems like an oversight?
Here’s the URL where you can see this:
https://dev.mafyvalmennus.fi/hello-world/GeneratePress 1.3.44GP Premium 1.2.94March 4, 2017 at 6:18 am #286930LeoStaffCustomer SupportMarch 4, 2017 at 6:24 am #286932Seppo
Did you check the URL? The H1 that’s used as the post title has a correct color, but ‘plain’ H1 applied in the WP post editor uses color setting applied to body element. Check the CSS on the page, there’s no other color applied on the H1 that’s within the post content.
Here’s what the settings in the Customizer look like: http://i.imgur.com/MCgmCQC.pngMarch 4, 2017 at 6:25 am #286933Seppo
And no, I don’t see it change in the preview.March 4, 2017 at 6:43 am #286948LeoStaffCustomer Support
Yes I did check the URL.
Just trying to get a little more info because it’s working for me: http://www.screencast.com/t/KVMOUb1K
Weird that you are not even seeing the preview change. Will ask Tom to have a look 🙂March 4, 2017 at 10:23 am #287049TomLead DeveloperLead DeveloperMarch 4, 2017 at 11:11 am #287064Seppo
This is weird, but you do see the problem in the URL I pasted to the first post? There’s clearly no color applied to the H1, the only color declaration that applies to it comes from the body tag. Anyway, I can fix this with custom CSS.March 4, 2017 at 11:13 am #287066TomLead DeveloperLead Developer
By default no color is applied to the H1 elements.
When you go into the Customizer and look at that option (Customize > Colors > Content > Heading 1 (H1)), is there a color saved?March 4, 2017 at 11:31 am #287072Seppo
Yes, see the imgur link I posted above.March 4, 2017 at 11:40 am #287078TomLead DeveloperLead Developer
Huh, that’s very strange. Can’t replicate on my side.
Any chance you can send me temporary admin login details?: https://generatepress.com/contact/March 4, 2017 at 11:50 am #287083Seppo
I sent you the login details. Just to say it again, this is not a problem for me. I just wanted to let you guys know since this behavior was unexpected.March 4, 2017 at 4:42 pm #287153TomLead DeveloperLead Developer
Ha, well that was a weird bug!
The class that creates the dynamic CSS checks to see if the same CSS has already been added before.
In this case, it was thinking .entry-content h1 == h1 (your content title and H1 values are the same), so it wasn’t adding the h1 color.
Appreciate the heads up! Fixed in the next version 🙂March 5, 2017 at 12:59 am #287235Seppo
Glad to hear you figured out what’s wrong and I wasn’t crazy 😀March 5, 2017 at 9:20 am #287407TomLead DeveloperLead DeveloperJuly 8, 2017 at 3:24 pm #346176Doug
Having almost the same issue… my H1 tag respects the text color but not the background…for page and post titles for example. Am I missing something here?
- You must be logged in to reply to this topic.