GP Theme v1.3.23 update breaks Tertiary Menu

[Mo]

Hi Tom,
This time it’s for real:)

You might recall the tertiary menu mod that you helped me on.

After transferring the Dev site to the live domain, it all was good.

Then today I noticed that the Tertiary menu wasn’t collpsing properly.

A down-aroow caret appears on the right hand side of the navbar and the height of the navbar is about double what it should be.

Disabled and re-enabled all plugins with no remedy.

After hours of attempting to troubleshoot, the reason for the glitch was the latest GP Theme update.

GeneratePress v1.3.21 to v1.3.23

Tertiary menu fine before update, broken after update.

This occurred on both the Dev site and the live site.

Fortunately I always make backups so reverting to the previous theme install corrects the issue.

Can you spot anything unusual as it’s way too complicated for my coding abilities?

The “Under Construction” page has been disabled until you’ve been able to have a look.

First time an update has impacted the tertiary menu.

Dev site.

Thanks.

[Tom]

Hi there,

1.3.23 rebuilt the entire dropdown and mobile menu functionality to be lighter and more extendable.

Looks like you need some more CSS:

.tertiary-navigation li {
    position: relative;
}

.tertiary-navigation ul {
    list-style: none;
    margin: 0;
    padding-left: 0;
}

.tertiary-navigation ul ul {
    box-shadow: 0 3px 3px rgba(0, 0, 0, 0.2);
    display: none;
    float: left;
    position: absolute;
    top: 1.5em;
    left: 0;
    z-index: 99999;
    width: 200px;
    text-align: left;
}

Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/
Ongoing Development: https://generatepress.com/ongoing-development

[Mo]

Hi Tom,
That did it!
As usual, great support!
Thanks.

[Tom]

You’re welcome 🙂

Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/
Ongoing Development: https://generatepress.com/ongoing-development

[Mo]

HI Tom,

Just a little item missing from the tertiary menu that was fixed after the footer code updat late last year.

I just noticed this morning that the up arrow caret was missing from the “Legal” button on the teritiary menu.

Hopefully it’s only a minor CSS adjustment?

Homepage

No panic on it.
Whenever you have a moment.
Thanks.
Mo

[Tom]

Ah, you’ll have to use this function to add the arrow to the tertiary navigation: http://pastebin.com/9F8aMMNt

Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/
Ongoing Development: https://generatepress.com/ongoing-development

[Mo]

The pastebin code was added to the functions.php file in the child theme but an arrow did not appear.
Removed it from the functions.php file and placed it in the navigation.js file but that didn’t work either.

The navigation.js code had this snippet at the end:

jQuery(window).load(function($) {
	
	// Add dropdown toggle that display child menu items.
	jQuery( '.tertiary-navigation .page_item_has_children > a, .tertiary-navigation .menu-item-has-children > a' ).after( '<a href="#" class="dropdown-toggle" aria-expanded="false"><i class="fa fa-caret-down"></i></a>' );

});

Is this causing a conflict of some sort?

Homepage

[Tom]

functions.php is the correct place for that code.

Do you recall what we named the theme location for that menu? The code assumes it’s just named “tertiary”.

Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/
Ongoing Development: https://generatepress.com/ongoing-development

[Mo]

It’s all good now Tom.

In the GP Hooks, a location wasn’t specified.

Removing ‘Tertiary’ from the functions code you sent did the trick.

The arrow appeared and only had to be flipped to point up.

Thanks for the awesome support!

Mo

[Tom]

Glad I could help 🙂

Documentation: http://docs.generatepress.com/
Adding CSS: http://docs.generatepress.com/article/adding-css/
Ongoing Development: https://generatepress.com/ongoing-development

[Author]

Posts