- This topic has 13 replies, 3 voices, and was last updated 4 years, 2 months ago by Tom.
August 21, 2017 at 5:29 am #370346NBC
The upgrade to 1.4/1.4.3 deleted my footer/copyright text altogether and replaced it with a generic GP copyright notice. Fortunately, I had saved a PDF of every page of the pre-upgrade site and was able to copy and paste the text from there, although I have no idea what size 10.5-point type is in pixels. (Acrobat Pro doesn’t comprehend pixels as a measurement of type.)
The problem I can’t seem to solve is that the Font Awesome Twitter icon in my menu bar has turned black, which (with a black menu bar) is the same thing as being invisible. The icon’s still there because the link shows up in the browser status line when you hover your cursor at the right end of the menu bar.
How/where do I fix this? The menu text color is set to white.
Everything was fine until I upgraded. 8-(GeneratePress 1.4GP Premium 1.4.3August 21, 2017 at 8:31 am #370443LeoStaffCustomer SupportAugust 21, 2017 at 9:12 am #370486NBC
Please try the link again. Thank you!August 21, 2017 at 9:54 am #370531TomLead DeveloperLead Developer
Strange about the copyright – nothing has changed in that code for months. What versions did you update from?
As for the Font Awesome icon, can you try clearing your Autoptimize cache/any other caching plugins you might be using?August 21, 2017 at 10:29 am #370552NBC
No caching plug-ins per se, but I cycld Autoptimize.
No change. Still no Twitter icon.August 21, 2017 at 10:32 am #370557TomLead DeveloperLead DeveloperAugust 21, 2017 at 10:34 am #370559NBC
“cycled Autoptimize” (yes, I actually do know how to type, appearances to the contrary)
BTW, I went from GP 1.3.48 and GPP 1.3.1 to GP 1.4 and GPP 1.4.3.August 21, 2017 at 10:43 am #370571TomLead DeveloperLead Developer
Ah, you’re using the Font Awesome Essentials filter, which only includes the essential icons that GP needs to work: https://docs.generatepress.com/article/generate_fontawesome_essentials/
If you remove that function, the entire FA library will load and you’ll be able to see the Twitter icon.August 21, 2017 at 10:44 am #370572NBC
Disabled Autoptimize. No change. (BTW, I followed your recommendations to the letter.)
Also tried commenting out your PHP code to reduce down FA for speed’s sake. No change.
I’m following most but not quite all of your optimization recommendations, BTW.
Disable emojisAugust 21, 2017 at 10:45 am #370574TomLead DeveloperLead DeveloperAugust 21, 2017 at 10:58 am #370582NBC
That did it.
I kept editing the copy of functions.php associated with the version of the site on my localhost dev server. 🙂 Not so difficult to understand when you realize that I only made this site live online last night. I’m launching my Kickstarter project on Wednesday.
I thought the FA-pruning code spared any glyphs in use on an active site. AFAIK, all I need are the menu arrow and the Twitter logo, unless GP relies on anything else. Building a custom typeface is tricky without a current font-editing tool. All I have is an ancient edition of Fontographer, and that won’t work with OpenType.August 21, 2017 at 11:09 am #370590TomLead DeveloperLead Developer
I would like to figure out a way to let people choose the icons they want to load – hopefully a future feature.
GladI was able to help 🙂August 21, 2017 at 11:37 am #370606NBC
I’ve been working on this site and the concept underlying it for more than a year. GP/GPP really made a big difference!August 21, 2017 at 11:38 am #370607
- You must be logged in to reply to this topic.