Site logo

[Resolved] Extend sidebar full length of page

Home Forums Support [Resolved] Extend sidebar full length of page

Home Forums Support Extend sidebar full length of page

Viewing 13 posts - 1 through 13 (of 13 total)
  • Author
    Posts
  • #167173
    Tony

    Is here a way to have the sidebar extend as far down the page as the main page goes.
    Not move down with it just continue down as empty white space .
    I think it looks odd when I scroll down and the sidebar comes to an end and the width of the site becomes 25% narrower and off-set to one side i.e. not centred. I don’t have much in the sidebar so the bottom may be seen on a large screen.

    • This topic was modified 10 years, 6 months ago by Tony. Reason: added to
    #167193
    Tom
    Lead Developer
    Lead Developer
    #167200
    Tony

    There is no final solution although I assume the update took place. Or am I missing something?

    Added this to wp-footer
    https://gist.github.com/generatepress/b946892d810435352fd9

    Added this to Simple CSS and tried Custom CSS
    .inside-article {
    -moz-box-sizing: border-box;
    -webkit-box-sizing: border-box;
    box-sizing: border-box;
    }

    Did not make any change to sidebar

    • This reply was modified 10 years, 6 months ago by Tony.
    #167204
    Tom
    Lead Developer
    Lead Developer

    The solution is in this post: https://generatepress.com/forums/topic/equal-length-columns/page/2/#post-38550

    What you did should have worked – can you link me to your site?

    #167208
    Tony

    I deleted the previous css and hook.

    I have added this to simple css
    .site-main {
    background:#FFF;
    }

    and this to GP Hooks wp-footer

    https://gist.github.com/generatepress/b946892d810435352fd9

    The side bar has not changed

    http://www.loveitphotography.uk

    #167222
    Tony

    Since last post I have re jigged the layout to use a single container and put everything in a 1500px container.

    It looks much better so will probably also look better with the full length sidebar.

    What about putting a thin bar down the side of the sidebar in the one container?

    Maybe both options???

    #167223
    Tom
    Lead Developer
    Lead Developer

    That will still require the script to make the two containers the same height – I’m not seeing the script in your footer so I assume you removed it?

    #167226
    Tony

    I replied to the email
    code is still in footer and css

    #167228
    Tom
    Lead Developer
    Lead Developer

    You added the link to your footer – you want to add the code which you can see by clicking on the link: https://gist.github.com/generatepress/b946892d810435352fd9

    #167230
    Tony

    Oh, it works now!

    I just took it literally – thought that the code was picked up from the link. (I did look at the code)

    Anyway DOH! and thanks for your patients.

    Q1 – Do you see any issue with constaining the site width to 1500px? It is responsive so will fit smaller screens and seems to look OK in a wider screen too. Any thoughts on optimum width?

    Q2 – I have made a few additions to the custom css. If I email them to you would you be kind enough to tell me if they include any errors/issues if you get time or if they could/should maybe go in the simple css instead?

    #167284
    Tom
    Lead Developer
    Lead Developer

    Glad it’s working 🙂

    1. No issues with that – the site is responsive regardless of the container width.

    2. Your best bet is to use a tool like this: https://jigsaw.w3.org/css-validator/#validate_by_input

    It will tell you if there’s any errors in your CSS.

    #167310
    Tony

    I believe my site looks a LOT better with the extended sidebar – perhaps this could be an option in a future release?

    Not so much errors in the CSS but if there is anything that is/may conflict with the theme and addons.

    #167411
    Tom
    Lead Developer
    Lead Developer

    It may be something I add into one of the add-ons, but it hasn’t been requested very much and would require another javascript file to be added to the plugins which I’m not too keen on.

    I’ll definitely keep it in mind though 🙂

    Nothing I can think of when it comes to conflicts, I think you’re good to go.

Viewing 13 posts - 1 through 13 (of 13 total)
  • You must be logged in to reply to this topic.