- This topic has 8 replies, 2 voices, and was last updated 5 years ago by Tom.
February 8, 2016 at 5:39 am #171281ian
Hope you are being a good dad
I feel that that dates/times should not be links (I could be wrong)
Issues in the following places (might be others I have not seen)
On the home/posts page if you have a date shown the date link takes you to the post
Not the end of the world but slightly confusing if there are more than one post published on the same day. In which case it should probably take you to all posts on that day.
On a single post page if you have a date shown the date link takes you to the post ie takes you nowhere ?
When comments have been left the date/time is shown this is a link that takes you back to the comment ?
My suggested solution is that these date/times should just be plain text
Also would like a way to remove time but leave date when comments are left. I cant work out if CSS can do this
I hope that makes sense
IanFebruary 8, 2016 at 6:35 am #171303TomLead DeveloperLead Developer
This is pretty standard in WP blogging, the reason is it gives Google and other search engines one more link to your post to follow.
It also makes sure that if you don’t have a post title, Google can still access your post via the date.
Of course, you can remove it with this function: https://gist.github.com/generatepress/429d8f954419921f564fFebruary 9, 2016 at 9:27 am #171580ian
I have to disagree links should not be there that can confuse the user just to help google and SEO
The function you pointed does work thank you
but it does not deal with date/time link when comments have been left ?
also won’t I now have to be careful when GP is updated ?
My preferred solution would be for next version of GP in blog content to allow the following for date
SHOW DATE/TIME WITH LINK
SHOW DATE WITH LINK
SHOW DATE/TIME WITH NO LINK
SHOW DATE WITH NO LINK
At present the Date Show/Hide has no effect in the comment area I think it probably should
Depending on type of Blog (frequency of posting) is why TIME is sometimes required as well as date
Don’t think this will cause any legacy issues
Maybe I should have put this in suggestions sorry
IanFebruary 9, 2016 at 8:42 pm #171699TomLead DeveloperLead Developer
If you used these directions you won’t have to worry about updates: https://generatepress.com/knowledgebase/adding-php-functions/
It’s definitely something for me to think about. Like I said, it would need to know whether the post had a title or not, if there’s no title, WordPress.org requires something to link to the full post – in this case (and almost every other WordPress theme), it’s the date.February 10, 2016 at 2:23 pm #171920ian
Hi Further thoughts
It’s definitely something for me to think about. Like I said, it would need to know whether the post had a title or not, if there’s no title, WordPress.org requires something to link to the full post – in this case (and almost every other WordPress theme), it’s the date.
You already have show/hide date so if there is no title this is already a problem ?
I just want to show the date but no link
you pointed out
Of course, you can remove it with this function: https://gist.github.com/generatepress/429d8f954419921f564f
Can this be modified so that the date shown can include the time?
Also can something similar be done for the date/time shown with every comment
ie no link just date no time
Many thanks again
February 12, 2016 at 9:21 am #172327TomLead DeveloperLead Developer
- This reply was modified 5 years ago by ian.
Yes, if you choose to remove the date completely, you’re choosing to remove that link as well.
This function will remove the link and add the time: https://gist.github.com/generatepress/0f8869c4a1b96f8e1ca1
The link in the comments makes it possible for people to link to specific comments, which can be very important for user experience.
You can add this function to remove it: https://gist.github.com/generatepress/21b8e4b706caf59470b7
When it comes to adding options, I need a good push from multiple people to consider it – currently you’re the only person to ever want these changes, so that’s why we have these awesome functions we can overwrite 🙂February 13, 2016 at 3:49 am #172488ian
Thanks for all that think it gives me all the options I need
Need some time to try a few things out
Totally understand you not wanting add options to GP it is one reason I like it because it is so lean but powerful.
Perfecting happy to modify with CSS and by overwriting functions when I can work out how and where.
That is where your amazing support comes in
My suggestions were just that MINE you have the overview of what is required to keep GP what it is and keep the majority happy
IanFebruary 13, 2016 at 3:51 am #172489ian
Forgot to ask how long does the code stay in “gist.github.com”
Or should I copy it somewhere locally soon ?February 13, 2016 at 8:45 am #172530
- You must be logged in to reply to this topic.