dumux-repositories issueshttps://git.iws.uni-stuttgart.de/groups/dumux-repositories/-/issues2021-05-06T08:56:37Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1024Richards test do not converge2021-05-06T08:56:37ZDennis GläserRichards test do not convergeIt seems that after !2574, some richards tests don't converge anymore, causing all pipelines to fail: https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/pipelines/3789
I only checked one output log and saw that `test_richards_b...It seems that after !2574, some richards tests don't converge anymore, causing all pipelines to fail: https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/pipelines/3789
I only checked one output log and saw that `test_richards_benchmark_infiltration_tpfa` fails due to timeout with poor newton convergence. There may be more tests affected.
In the MR I see that at the latest stage at least, there was no pipeline triggered. Did you test locally before merge @heck, @timok ?3.4https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/955Backport !2139 (RANS density) to 3.22020-10-31T09:57:01ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deBackport !2139 (RANS density) to 3.2!2139 could not be cherry-picked automatically. You need to do it by hand.!2139 could not be cherry-picked automatically. You need to do it by hand.Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/844Wrong dkrn_dswe analytical derivative in Brooks-Corey and Van Genuchten2020-03-31T08:02:07ZTheresa SchollenbergerWrong dkrn_dswe analytical derivative in Brooks-Corey and Van GenuchtenThe implementation of the analytical derivative dkrn_dswe in the Brooks-Corey law is not correct. This is also shown by a comparison with the numerical derivative.
Implemented derivative: $`\frac{d krn}{d swe} = 2 (swe -1) (1+\frac{1}{\...The implementation of the analytical derivative dkrn_dswe in the Brooks-Corey law is not correct. This is also shown by a comparison with the numerical derivative.
Implemented derivative: $`\frac{d krn}{d swe} = 2 (swe -1) (1+\frac{1}{\lambda} \cdot swe^{\frac{2}{\lambda}} + \frac{1}{2} - (\frac{1}{2}+\frac{1}{\lambda}) \cdot swe)`$
Correct derivative: $`\frac{d krn}{d swe} = 2 (swe -1) (1+(\frac{1}{2} + \frac{1}{\lambda}) \cdot swe^{\frac{2}{\lambda}} - (\frac{3}{2}+\frac{1}{\lambda}) \cdot swe^{\frac{2}{\lambda}+1})`$
![dkrndSw](/uploads/6ae2e8e4116184f902d7d0a1a61858eb/dkrndSw.png)
Additionaly there is also an error in the analytical derivative dkrn_dswe in the Van Genuchten law.
Implemented derivative: $`\frac{d krn}{d swe} = -(1-swe)^{\gamma-1}\cdot(1-swe^{\frac{1}{m}})^{2m-1}\cdot (\gamma(1-swe^{\frac{1}{m}}) - 2\frac{1-swe}{swe} swe^{\frac{1}{m}})`$
Correct derivative: $`\frac{d krn}{d swe} = -(1-swe)^{\gamma-1}\cdot(1-swe^{\frac{1}{m}})^{2m-1}\cdot (\gamma(1-swe^{\frac{1}{m}}) \color{red}+ \color{black} 2\frac{1-swe}{swe} swe^{\frac{1}{m}})`$
![dkrndSw_vanGenuchten](/uploads/a5a6da85cf8b39c6d2c0aed9587edd3b/dkrndSw_vanGenuchten.png)3.2Theresa SchollenbergerTheresa Schollenbergerhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/662Wrong use of extrusion factors (freeflow)2019-02-27T09:56:07ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deWrong use of extrusion factors (freeflow)At certain points, the use of the extrusion factor is implemented wrong:
* fluxoversurface.hh lacks the factor for the calculation of the volume fluxes
* stokesdarcy/couplingdata.hh includes the factor in the calculation of diffusive fl...At certain points, the use of the extrusion factor is implemented wrong:
* fluxoversurface.hh lacks the factor for the calculation of the volume fluxes
* stokesdarcy/couplingdata.hh includes the factor in the calculation of diffusive fluxes, however, those values
are then applied as Neuman-BCs where the factor is again applied
__TODO__ @heck What about the Maxwell-Stefan fluxes in the coupling data?3.1Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/469Compiler warnings2018-10-31T15:52:12ZThomas FetzerCompiler warningsWe should fix or at least discuss whether we want to fix the following compiler warnings (I am aware that DUNE prints a lot of this warnings, too).
* [x] -Wshadow (shadowing of local variables, e.g. by lambda functions or if/for loops)
...We should fix or at least discuss whether we want to fix the following compiler warnings (I am aware that DUNE prints a lot of this warnings, too).
* [x] -Wshadow (shadowing of local variables, e.g. by lambda functions or if/for loops)
* [x] -Wno-missing-braces -Wmissing-field-initializers (initiliazation, e.g. object({}) vs object{{}} )
* [x] -Wunused-result (e.g. #472)
* [x] -Wfloat-equal3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/364Correct handling of diffusive fluxes2018-07-26T11:46:43ZDennis GläserCorrect handling of diffusive fluxesIn the seminar we came up with the following strategy:
- [x] When useMoles = false we will have to add the diffusive fluxes to the total mass balance equation (eqIdx = replaceCompIdx)
- [x] Fick's law will always be mole based (as in it...In the seminar we came up with the following strategy:
- [x] When useMoles = false we will have to add the diffusive fluxes to the total mass balance equation (eqIdx = replaceCompIdx)
- [x] Fick's law will always be mole based (as in its derivation). However, the fluxes are transformed into mass fluxes if useMoles = false
- [x] Update documentation
- [x] Return vector of fluxes from fick's law and think about maxwell-stefan diffusion when implementing it
3.0Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/474[material][brine] Implement brine fluid system and brine pseudo component2018-07-20T15:18:13ZTimo Kochtimokoch@math.uio.no[material][brine] Implement brine fluid system and brine pseudo componentBrine is currently a pseudo component but extends the interface to be able to have variable salinity. A mixture with variable salinity is however a fluid system. We should implement both interface (brine as fluidsystem and brine as pseud...Brine is currently a pseudo component but extends the interface to be able to have variable salinity. A mixture with variable salinity is however a fluid system. We should implement both interface (brine as fluidsystem and brine as pseudocomponent with constant salinity) classes separately.3.0