Author page displaying when blank

Hi Steve,

What specific type of Element are you using? Is this a Block Element - Content Template?

I have two setup like:
https://imgur.com/a/dw2zqra

I'm adding a link to the elements export file

If you temporarily disable these elements, does the issue still occur? If so, it might be best to reach out iThemes Security as these Elements are just hooking to available pages.

When I disable the elements I get a proper 404 page, so this appears to be something going on with the Elements on this.

Hi there,

in the case of author archives that have no Posts, what would you want to display in there place ? Or would you sooner it just correctly 404 error ?

Yes exactly, it should 404. The rationale is it exposes user logins, so a 404 would be ideal.

I just tried this out with a madeup URL (/author/testing123) and it 404's properly, so it does let a little bit of info out here by rendering this as it does.

Thanks for your help!

Hmmm... odd one this, as i am sure we use the is_author() template tag for that author archive display rules which should return false IF the author has no posts....

What happens if you add this snippet:

add_filter( 'generate_element_display', function( $display, $element_id ) {
    if ( 100 === $element_id &&  !is_author() ) {
        $display = false;
    }

    return $display;
}, 10, 2 );

Change the 100 to match the author archive Content Templates ID.

Hmm, I tried this snippet with both the Content Template ID and the Author Archive Page Hero ID and nothing changed for either.

I also tried deactivating the ithemes security feature to hide archive pages for authors without posts and no change, same result which is kind of interesting as you'd expect it to maybe have the user's name and thumb for this.

I am using Dynamic Data for Headline block and 'Post author name' as the selection. Not sure if this is the possible issue? It seems to be displaying that hero content element either way.

Can you try this instead?:

add_filter( 'generate_element_display', function( $display, $element_id ) {
    if ( 100 === $element_id &&  $GLOBALS['wp_query']->found_posts < 1 ) {
        $display = false;
    }

    return $display;
}, 10, 2 );

Replace 100 with the Block Element ID.

That works, mostly.

It does present a page with a line on it, so while that page hero area is gone, there is still a page that is a true 404 page.

Feel free to check out the link.

You'll need to exclude the ID of the Content template as well. It's still displaying.

Use this instead:

add_filter( 'generate_element_display', function( $display, $element_id ) {
	$my_element_ids = array( 100, 101 );
    if ( in_array( $element_id, $my_element_ids) &&  $GLOBALS['wp_query']->found_posts < 1 ) {
        $display = false;
    }

    return $display;
}, 10, 2 );

Replace 100, 101 with the IDs of the Elements you which to exclude. Make sure the Content Template - Block Element ID is in the array as well.