- This topic has 12 replies, 2 voices, and was last updated 4 years, 4 months ago by
Leo.
-
AuthorPosts
-
February 4, 2019 at 10:07 am #801210
Anil
Please advise how to place logo left to site title and site description
February 4, 2019 at 10:33 am #801233Leo
StaffCustomer SupportHi there,
Give this a shot:
https://docs.generatepress.com/article/putting-site-title-next-logo/February 4, 2019 at 10:52 am #801249Anil
Leo css worked.
As suggested there created logo with site title, uploaded and hide site title and description.
But there is no h1 tag on the home page ???
February 4, 2019 at 10:57 am #801255Leo
StaffCustomer SupportI’m not sure what you mean.
Site title wasn’t using
<h1>
either.<h1>
is generally used for the page title.February 4, 2019 at 11:04 am #801261Anil
<div class="inside-header grid-container grid-parent"> <div class="site-branding"> <h1 class="main-title" itemprop="headline"> <a href="https://cubehut.com/" rel="home"> CubeHut </a> </h1> </div><div class="site-logo"> <a href="https://cubehut.com/" title="CubeHut" rel="home"> <img class="header-image" alt="CubeHut" src="https://cubehut.com/wp-content/uploads/2019/02/cubehut-logo.jpg" title="CubeHut" /> </a> </div> </div><!-- .inside-header -->
i just switched on site title, and it is evident from the source….
February 4, 2019 at 11:11 am #801272Leo
StaffCustomer SupportMy mistake.
The
title="CubeHut"
in the logo should take care of it though.I’ll confirm and report back 🙂
February 4, 2019 at 11:15 am #801274Anil
I noticed this earlier also with GP. It needs update……….
February 4, 2019 at 11:18 am #801275Anil
If you hide site-title and there is site-logo, then logo should be wrapped in h1 tag on home page and on other pages without h1 tag ………….. 😉
February 4, 2019 at 11:25 am #801280Leo
StaffCustomer SupportI checked with Tom and he suggested to either use the original method of logo + site title or add a page hero with
<h1>
element in it:
https://docs.generatepress.com/article/header-element-overview/Would be nice to do it by default, but we can’t add an H1 to everyone’s websites on an update.
Thanks for pointing this out 🙂
February 4, 2019 at 11:44 am #801304Anil
You are right.
either use the original method of logo + site title
with this i added in additional css
div.site-branding{display:none}
DO YOU SEE ANY PROBLEM WITH THIS CSS OR ANY EFFECT RELATED TO SEO….
February 4, 2019 at 11:49 am #801309Leo
StaffCustomer SupportSorry. By original method I meant separating the logo image and site title then use this CSS to make them next to each other:
https://docs.generatepress.com/article/putting-site-title-next-logo/That case you would have the
<h1>
in the site title.Let me know if this makes sense.
February 4, 2019 at 9:45 pm #801625Anil
This is fine Leo.
This seems to be a mistake/blunder in the theme development initially 🙁
February 4, 2019 at 11:02 pm #801652Leo
StaffCustomer SupportHmm not exactly.
There isn’t a good solution for this unfortunately.
This would only happen if the front page is used as the blog page and logo/no site title is used. If we add the h1 to the title, then that wouldn’t work for a lot of people who has their own H1 element added to the page.
On static pages, H1 element is stripped from the site title as it should be the content title.
The logo output is actually filterable:
https://docs.generatepress.com/article/generate_logo_output/ but I’m not sure where it would make sense to add an H1 element to an image. -
AuthorPosts
- You must be logged in to reply to this topic.