Archived topic
Accessibility
10 replies · Started by Jim on August 28, 2019
Hi Tom. I think it would make more sense to move the reply button in the comments box to below the comment. It sounds odd or out of place when using a screen reader in its current position because it shows before a comment is read. I read somewhere that GP 2.4 will rectify that?
Hi there,
yes, this topic shows a change has already been committed to GP 2.4 that will allow the reply to be moved:
https://generatepress.com/forums/topic/reply-link-at-the-bottom-of-the-comments/#post-983261
That is good! Let me play around with the code for now until the feature comes officially.
Edit: I found I had to remove this code for the reply button at the top to disappear. How will this be dealt with in GP 2.4 so as not to show two instances of "reply"?
<?php
comment_reply_link( array_merge( $args, array(
'add_below' => 'div-comment',
'depth' => $depth,
'max_depth' => $args['max_depth'],
'before' => '<span class="reply">| ',
'after' => '</span>',
) ) );
?>Did you follow Tom's instructions to just edit your parent theme comments.php and use the exact filter he provided to move the reply?
I have tested this on another build and there is no duplicate reply.
Yes, I did. I copied the whole comments.php code he provided but still, two instances of reply showed up http://prntscr.com/oz6ukj.
Could you link me to a post where i can see this?
Check the original post.
Right now you'd need to hide it with CSS. I may actually move it under the content by default in 2.4, as it does make more sense down there. I'll play with it.
Thanks!
You are welcome. Does that mean also we can do away with that function to move the location altogether with GP 2.4?
Yes, if we do decide to go that route (haven't solidified anything, yet).
Okay. Will be on the lookout for that.
