Premium support

Please log in to post in these forums. If you didn't create an account when you purchased, please contact us.

Free support

If you haven't purchased GP Premium, support for the free theme can be found on WordPress.org.

john770

Forum Replies Created

Viewing 15 posts - 1 through 15 (of 21 total)
  • Author
    Posts
  • in reply to: CSS files loaded twice (both parent + child theme) #426427

    Thanks Tom!
    Just for the record and for any users with the same problem or question (I just noticed I hadn’t reported back after having announced I would try your suggestion) – as you had predicted, removing the enqueuing code from the child’s function.php file solved the problem, thanks again for your advice!

    in reply to: CSS files loaded twice (both parent + child theme) #424495

    Thanks, Tom, that’s good to know. πŸ™‚

    Well, under these circumstances the question arises as to my future work with GP, do I need a child theme at all with GeneratePress? Given that I can use your plugin “Simple CSS” for CSS, then the “Code Snippets” plugin and WordPress hooks and filters for PHP snippets, what use cases can you think of where said tools are not enough and I would definitely need a child theme for GP?

    I guess one of the cases you’ll mention is when I wanted to change any theme templates themselves, right? Can you think of any other possible reasons, and would any of these imaginable reasons make it mandatory that I set up a child theme *right from the start* of a theme project or would it be enough to do so just when the need arises (given my use of the above mentioned tools)?

    Thanks a lot for your thoughts!
    I really appreciate your help and the many useful forum posts I am finding here and that I can learn from.

    in reply to: CSS files loaded twice (both parent + child theme) #423696

    I just checked the parent GP functions.php and it has

    
    	// Add the child theme CSS if child theme is active.
    	if ( is_child_theme() ) {
    		wp_enqueue_style( 'generate-child', get_stylesheet_uri(), array( 'generate-style' ), filemtime( get_stylesheet_directory() . '/style.css' ), 'all' );
    	}
    

    so I guess that’s the reason why, together with the enqueuing script in my child theme’s functins.php, the css file is loaded twice, right? It seems to depend on the parent theme, because I didn’t have that issue before.

    I’ll try and remove the whole enqueuing script from my child theme, as you suggested.

    Thanks again for your answer!

    in reply to: CSS files loaded twice (both parent + child theme) #423684

    Hello Tom,

    There’s no reason for that function in your child theme.

    Hmm, then I wonder why
    https://codex.wordpress.org/Child_Themes#How_to_Create_a_Child_Theme
    suggests:

    If your child theme style.css contains actual CSS code (as it normally does), you will need to enqueue it as well. Setting ‘parent-style’ as a dependency will ensure that the child theme stylesheet loads after it. Including the child theme version number ensures that you can bust cache also for the child theme. (See a more detailed discussion on Stack Exchange.) *The complete (recommended) example becomes*:

    
    <?php
    function my_theme_enqueue_styles() {
    
        $parent_style = 'parent-style'; // This is 'twentyfifteen-style' for the Twenty Fifteen theme.
    
        wp_enqueue_style( $parent_style, get_template_directory_uri() . '/style.css' );
        wp_enqueue_style( 'child-style',
            get_stylesheet_directory_uri() . '/style.css',
            array( $parent_style ),
            wp_get_theme()->get('Version')
        );
    }
    add_action( 'wp_enqueue_scripts', 'my_theme_enqueue_styles' );
    ?>
    

    You say

    If you remove it, the issue should go away.

    Do you mean I can remove that complete enqueuing script from my functions.php?
    Or only parts of it? I thought the enqueuing script was mandatory for a child theme.
    Thanks!

    in reply to: Failed to update to 1.5 #421244

    John,
    Another idea, since you don’t mention that point:
    Did you flush your browser cache, or, if so but without effect, any plugin cache in use?

    in reply to: Why my Site is not Responsive ? #419077

    I think it’s due to this CSS (see source code):
    <style id="rocket-critical-css">[...]body{min-width:767px}</style>

    in reply to: GP 1.5: Update failed #418866

    Everything OK after re-installing, it seems at first sight! Brilliant!
    Will look around now to discover the new goodies πŸ™‚
    Thanks again for the speedy help and for this great theme!

    in reply to: GP 1.5: Update failed #418850

    Thanks a lot for the speedy reply, Leo, I think you are spot on, cause I am using XAMPP on Windows.
    I’ll try the manual update.

    in reply to: Merge menu with header with Elementor #415863

    Thanks, Leo!

    in reply to: Merge menu with header with Elementor #415838

    Iain and Leo,
    In case a new thread has been opened, could you please leave a link here, at the end of this thread?
    I have been searching in vain and I am also interested in this topic.
    Thanks!

    in reply to: yoast breadcrums #404736

    Thank you very much for your explanation!

    in reply to: yoast breadcrums #404711

    Hey Jose,

    I have already solved. (edited single.php)

    Care to share how exactly you edited that file to solve the problem?
    Might be helpful for other users, too.
    Thanks!

    in reply to: Ease-in transition for mobile "Hamburger" dropdown menu #402206

    Wow, brilliant, thank you so much! πŸ™‚
    The only thing I had to add (latest Firefox) was width: 100% for the first declaration, since without it the menu items were half-covered and started at the height of the logo. Very nice, now I have the choice between two elegant mobile menus, thanks a lot again!

    BTW: One of the many things I really like about your theme is that I go to NU HTML Checker and the result is “Document checking completed. No errors or warnings to show.” Then on to the W3C CSS Validator and the result is “Congratulations! No Error Found”.* Try that with any of the big multi-purpose themes at ThemeForest or elsewhere…
    *Only exception are blog pages with comments: No errors indicated, but for every single article class="comment-body" there is an (unjustified) warning: “Warning: Article lacks heading. Consider using h2-h6 elements to add identifying headings to all articles”, which doesn’t make any sense at all in the comment body context, does it? πŸ™‚

    in reply to: Ease-in transition for mobile "Hamburger" dropdown menu #402081

    Hi Tom,

    That’s intentional, as people typically want instant results on mobile as opposed to transitions.

    That’s a good reason, for sure, and I also try to avoid transitions and animations that are bad for the site’s performance and for user experience.

    OTOH, you are using the elegant slide-in navigation for mobile view on this very site, and I wonder if the same effect or a similar one would be possible for the (IMHO not so elegant) mobile *drop-down* menu.

    FYI, in mobile view, my site in progress (on XAMPP) has the “navigation logo” on the left and the Hamburger icon on the right-hand side (display:inline-block and float:right).

    Here’s the HTML, in case you should like to see it:

    
    <nav>
    <div class="inside-navigation grid-container grid-parent">
    	<div class="site-logo sticky-logo navigation-logo">
    		<a href="http://localhost/mysite/" title="mysite" rel="home">
    			<img class="header-image" src="http://localhost/mysite/wp-content/uploads/2017/09/logo-mysite.png" alt="mysite">
    		</a>
    	</div>
    		<button class="menu-toggle" aria-controls="primary-menu" aria-expanded="true">
    			<span class="mobile-menu">Menu</span>
    		</button>
    	<div id="primary-menu" class="main-nav">
    		<ul id="menu-main-menu" class=" menu sf-menu">
    		...
    		</ul>
    	</div>
    </div><!-- .inside-navigation -->
    </nav>
    

    I had started with the mobile slide-in navigation, but changed to the drop-down menu after the menu items in the slide-in navigation were scrambled. This being the only thing that didn’t work so far with this great theme, I tried again after your above answer and got it working now – I had only enabled it in the Customizer, but had forgotten to additionally check “Slideout Menu” as the Display Location in the Menu Settings. πŸ™‚

    But, if you happen to know a way to give the mobile drop-down menu a similar transition as the one of the slide-in navigation, it would be great to learn about it and have *two* elegant mobile menus at hand.
    Thanks a lot for your help!

    in reply to: Ease-in transition for mobile "Hamburger" dropdown menu #401601

    Hi Tom,

    I am currently only testing on XAMPP, so I can’t link you to a live site. Just wanted to thank you swiftly for your answer, since, unfortunately, I haven’t got enough time for a detailed answer right now, but I will come back tomorrow.

Viewing 15 posts - 1 through 15 (of 21 total)