- This topic has 89 replies, 13 voices, and was last updated 5 years, 3 months ago by Leo.
-
AuthorPosts
-
October 1, 2014 at 8:14 am #35717Michael
I did get it to lengthen the main content panel to full length and sidebars too (by adding the script code to wp_footer hook) – except for those custom sidebars that I’ve created using the plugin “Custom Sidebars” by WPMU DEV – I’m assuming now that those sidebars are acting independently – I’ll have to take a look at the files associated with that plugin..
Anyway – thanks for the help!
mcOctober 1, 2014 at 12:10 pm #35752MichaelJust to follow up – I copied the script code in wp_footer and did notice that the ‘pages’ showed full length on screen, but then on 2nd look I noticed that any pages showing a list of same-category posts were rendering each post as full-page size (well past the “Read More” link).
I need the category/archive pages to show properly, so I removed the code from wp_footer.
I’ll take a closer look at the .php pages and functions.. do let us know if you know of a solution for this issue.
Not that big a deal, but getting consistent presentation and layout is preferred of course.
Thanks!
October 1, 2014 at 4:48 pm #35948AlexAny solution yet?
October 1, 2014 at 5:30 pm #35988TomLead DeveloperLead DeveloperWorking on it – it’s a little more complicated than expected unfortunately, unless you’re using one container. If you’re using Separate Containers, it gets a little crazy.
Hoping to have a solution ASAP.
October 4, 2014 at 9:32 am #36869Alexi’ve updated GP…is there a solution included ?
October 4, 2014 at 11:56 am #36899TomLead DeveloperLead DeveloperI’m getting closer, but the result isn’t consistent.
I have it working on my localhost, but I’m experiencing issues on live websites.
Rest assured that I’m working on it – I can see it’s a wanted feature, and I definitely want to make you guys happy! π
October 4, 2014 at 9:22 pm #37038AlexThanks, we – users of GP – appreciate it )
That is definitely needed to give more monolithic and proffesional look to websites.
Best,
October 11, 2014 at 12:34 pm #38550TomLead DeveloperLead DeveloperAlright, I’m happy to say we should finally have a solution π
First, you need to update to the latest version of Spacing or GP Premium.
Then, this updated code should work: https://gist.github.com/generatepress/b946892d810435352fd9
First, you’ll see I added some CSS in there. This is simply so you can see the sidebar reaches the same level as the content. I’ll be adding a new option to Colors soon that will allow you to choose the sidebar background color.
So, paste that code into the wp_footer area of GP Hooks, and you should be good to go.
Thanks!
*** UPDATE ***
If you want to use CSS only, you can do this:
.site-content { display: flex; } .sidebar { background: #f5f5f5; }
October 13, 2014 at 3:39 pm #38976AlexOh. thanks, but it just made worse. I deleted CSS from wp_footer temporarily.
The disqus comments are now behaving strange…
http://titanovo.com/myths-electroencephalography-eeg/October 13, 2014 at 3:41 pm #38979TomLead DeveloperLead DeveloperIt shouldn’t have done anything to the Disqus section – this is a known thing which I didn’t add integration for yet.
http://www.generatepress.com/forums/topic/background-for-disqus/
October 28, 2014 at 8:15 pm #42579Amanda MartinThanks for working on this Tom!
This isn’t going to be a problem for me but you might consider making it so that if the menu is longer than the main container then the main container grows to the same length at the menu. So they are always the same length.
Enjoy the coffee!! π
October 29, 2014 at 10:15 am #42694TomLead DeveloperLead DeveloperHi Amanda,
Thanks for the coffee!! π
The script should take the tallest element, and match the other to the same height – let me know if you have any problems with it.
October 30, 2014 at 9:27 pm #42936AmandaHere’s a page that I haven’t completed yet and the columns don’t line up.
http://www.vancouverhomeexchange.ca/neighbourhood/
As I said before not really a problem for me, more of a heads up.
October 31, 2014 at 10:21 pm #43240TomLead DeveloperLead DeveloperAh, to fix this, you would need to set a background color the main container.
Something like:
.site-main { background:#FFF; }
November 1, 2014 at 10:38 am #43354MichaelGreat job on this fix, Tom!
-
AuthorPosts
- The topic ‘Equal length columns’ is closed to new replies.